From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 348F917D2 for ; Sat, 6 Jan 2024 04:21:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Scd2Vxl2" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1704514915; x=1736050915; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=mBilgYmmWvnzHNgPRu5X/8Sdp74P0JzNXf6aWiYwelQ=; b=Scd2Vxl2Q2wMZZyvKDlbeO6wzGT8BeKmRTL+TTPiMhntm69dzfxnnoFc e/C8YgJnDs3B07SOz093rBmjcBuKzbVpuCAxEuOJgckOF/jJUx7ADwqLw ZafWTBaHT/fOo+evP/ATliFTXL05CY4tcj/HpqX+AuS1F/I3IwqTLxv2r CKa42htJQb7sSfk2BeelwpUUSaZqNY2r9DoUyAPwmB7Msle3rWkB99wgn EZPeeXpe+OsBvcKlUwrPDM7JXVke6FuWALs7nFErwednWZ/l2nJHNHdJb L0ny/8gEhCTk3FPRSY/dq9yKML3IFfrh4YHzx2iZLfAKKfup/rJSwhitL Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10944"; a="461932857" X-IronPort-AV: E=Sophos;i="6.04,335,1695711600"; d="scan'208";a="461932857" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2024 20:21:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,335,1695711600"; d="scan'208";a="15418641" Received: from zhaohaif-mobl.ccr.corp.intel.com (HELO [10.93.16.94]) ([10.93.16.94]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2024 20:21:52 -0800 Message-ID: Date: Sat, 6 Jan 2024 12:21:49 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] iommu/iova: Make the rcache depot properly flexible To: Ido Schimmel , Robin Murphy Cc: joro@8bytes.org, will@kernel.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, zhangzekun11@huawei.com, john.g.garry@oracle.com, dheerajkumar.srivastava@amd.com, jsnitsel@redhat.com References: From: Ethan Zhao In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/2/2024 3:24 PM, Ido Schimmel wrote: > On Thu, Dec 28, 2023 at 02:23:20PM +0200, Ido Schimmel wrote: >> On Tue, Sep 12, 2023 at 05:28:04PM +0100, Robin Murphy wrote: >>> v2: https://lore.kernel.org/linux-iommu/cover.1692641204.git.robin.murphy@arm.com/ >>> >>> Hi all, >>> >>> I hope this is good to go now, just fixed the locking (and threw >>> lockdep at it to confirm, which of course I should have done to begin >>> with...) and picked up tags. >> Hi, >> >> After pulling the v6.7 changes we started seeing the following memory >> leaks [1] of 'struct iova_magazine'. I'm not sure how to reproduce it, >> which is why I didn't perform bisection. However, looking at the >> mentioned code paths, they seem to have been changed in v6.7 as part of >> this patchset. I reverted both patches and didn't see any memory leaks >> when running a full regression (~10 hours), but I will repeat it to be >> sure. > FYI, we didn't see the leaks since reverting these two patches whereas > before we saw them almost everyday, so I'm quite sure they introduced > the leaks. Seems some magazines were not freed when one CPU is dead (hot unplugged) ? static void free_cpu_cached_iovas(unsigned int cpu, struct iova_domain *iovad) {     struct iova_cpu_rcache *cpu_rcache;     struct iova_rcache *rcache;     unsigned long flags;     int i;     for (i = 0; i < IOVA_RANGE_CACHE_MAX_SIZE; ++i) {         rcache = &iovad->rcaches[i];         cpu_rcache = per_cpu_ptr(rcache->cpu_rcaches, cpu);         spin_lock_irqsave(&cpu_rcache->lock, flags);         iova_magazine_free_pfns(cpu_rcache->loaded, iovad); +     iova_magazine_free(cpu_rcache->loaded);         iova_magazine_free_pfns(cpu_rcache->prev, iovad); +     iova_magazine_free(cpu_rcache->prev);         spin_unlock_irqrestore(&cpu_rcache->lock, flags);     } } Thanks, Ethan > Thanks >