* [PATCH] md/raid5: unset WQ_CPU_INTENSIVE for raid5 unbound workqueue
@ 2025-06-01 1:37 Ryo Takakura
2025-06-02 17:23 ` Tejun Heo
2025-06-14 6:42 ` Yu Kuai
0 siblings, 2 replies; 3+ messages in thread
From: Ryo Takakura @ 2025-06-01 1:37 UTC (permalink / raw)
To: song, yukuai3, tj; +Cc: linux-raid, linux-kernel, Ryo Takakura
When specified with WQ_CPU_INTENSIVE, the workqueue doesn't
participate in concurrency management. This behaviour is already
accounted for WQ_UNBOUND workqueues given that they are assigned
to their own worker threads.
Unset WQ_CPU_INTENSIVE as the use of flag has no effect when
used with WQ_UNBOUND.
Signed-off-by: Ryo Takakura <ryotkkr98@gmail.com>
---
Hi!
My understanding is that unbound wqs are served by non concurrency
managed worker threads and is not tracked by wq_cpu_intensive_report(),
so this should have no change in behaviour.
Sincerely,
Ryo Takakura
---
drivers/md/raid5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 638938316..8f3b45161 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -9048,7 +9048,7 @@ static int __init raid5_init(void)
int ret;
raid5_wq = alloc_workqueue("raid5wq",
- WQ_UNBOUND|WQ_MEM_RECLAIM|WQ_CPU_INTENSIVE|WQ_SYSFS, 0);
+ WQ_UNBOUND|WQ_MEM_RECLAIM|WQ_SYSFS, 0);
if (!raid5_wq)
return -ENOMEM;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] md/raid5: unset WQ_CPU_INTENSIVE for raid5 unbound workqueue
2025-06-01 1:37 [PATCH] md/raid5: unset WQ_CPU_INTENSIVE for raid5 unbound workqueue Ryo Takakura
@ 2025-06-02 17:23 ` Tejun Heo
2025-06-14 6:42 ` Yu Kuai
1 sibling, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2025-06-02 17:23 UTC (permalink / raw)
To: Ryo Takakura; +Cc: song, yukuai3, linux-raid, linux-kernel
On Sun, Jun 01, 2025 at 10:37:02AM +0900, Ryo Takakura wrote:
> When specified with WQ_CPU_INTENSIVE, the workqueue doesn't
> participate in concurrency management. This behaviour is already
> accounted for WQ_UNBOUND workqueues given that they are assigned
> to their own worker threads.
>
> Unset WQ_CPU_INTENSIVE as the use of flag has no effect when
> used with WQ_UNBOUND.
>
> Signed-off-by: Ryo Takakura <ryotkkr98@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] md/raid5: unset WQ_CPU_INTENSIVE for raid5 unbound workqueue
2025-06-01 1:37 [PATCH] md/raid5: unset WQ_CPU_INTENSIVE for raid5 unbound workqueue Ryo Takakura
2025-06-02 17:23 ` Tejun Heo
@ 2025-06-14 6:42 ` Yu Kuai
1 sibling, 0 replies; 3+ messages in thread
From: Yu Kuai @ 2025-06-14 6:42 UTC (permalink / raw)
To: Ryo Takakura, song, tj; +Cc: linux-raid, linux-kernel, yukuai (C)
在 2025/06/01 9:37, Ryo Takakura 写道:
> When specified with WQ_CPU_INTENSIVE, the workqueue doesn't
> participate in concurrency management. This behaviour is already
> accounted for WQ_UNBOUND workqueues given that they are assigned
> to their own worker threads.
>
> Unset WQ_CPU_INTENSIVE as the use of flag has no effect when
> used with WQ_UNBOUND.
>
> Signed-off-by: Ryo Takakura<ryotkkr98@gmail.com>
> ---
Applied to md-6.16
Thanks
Kuai
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-14 6:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-01 1:37 [PATCH] md/raid5: unset WQ_CPU_INTENSIVE for raid5 unbound workqueue Ryo Takakura
2025-06-02 17:23 ` Tejun Heo
2025-06-14 6:42 ` Yu Kuai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).