From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 748F74192FD for ; Mon, 20 Jul 2026 12:40:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784551218; cv=none; b=KGDxmuUsxe6wkBzdPE1f6H1yG7PJDdlidk3v+F0ZftcaehD0zxFhWewqlIzQKgxbodPSCaXcFRnzeft5XlGQp2KtwGkgHUDKhbjO9HV8q+DhMETmfiBKGrCpN70jOr8hkU6LQtSrl75+Xq+X8eVpCok6vpXPZOcVXC9qjydYuQ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784551218; c=relaxed/simple; bh=v1xXT4QifE7AOWhUqqczNrWqP+9RVCafb0eI82UlxeM=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=NPRoGn4pr7S9jlTE85eabdVzeiLbmaiiX25UwEvlbfhZyD0m41buldVkHlfUYQrAmqjmA8+CmptZJeQk1o65q7RTH6fQGBv+C1WwwBlsH2LOd3GlXtfhDK3SIWlKBFFcl5bO2+vtdIMc2VhZUp5D2LEGXcqz8Z+s9nKP85+CTNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZcE3EERf; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZcE3EERf" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-47ddf7b09e5so6260412f8f.1 for ; Mon, 20 Jul 2026 05:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1784551213; x=1785156013; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rFXYaVGgGEb7joixlU0w7k5auPqDLVpSrfyhDN1sfkc=; b=ZcE3EERfZnu+ZJ3Zvlw5vtJYnGynsx1/addigoM9Ptvb3+Vosfo/MkDAqacO3oTIhJ grSIdhi4aDrYGs+5YUwAwkqJ/JWBCC4PiAtQHUZSzeoubPjdcWenJ8PDHtbNEg+SNQC5 PYMDxQMg5Iz7WErOrYghZE/dbRXdyROhJ+40T/2WKS6YhtqqUznlbH4zuFbHmn5nQYmf pAk2Z7gCCWqQlgA4r1E7yvqChk26Qia9TsBaUKeulmgVzFkVPt7Utm0t3kGpbtwq/AB1 4FNDtXAHhWv7BGOwYn7oGCWJkYsWstH2IloXxnGGiw8v9qGqj3pJ2n3EupswPJLRUnVL gMkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784551213; x=1785156013; h=content-transfer-encoding:content-type:in-reply-to:organization :autocrypt:content-language:references:cc:to:subject:reply-to:from :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to:content-type; bh=rFXYaVGgGEb7joixlU0w7k5auPqDLVpSrfyhDN1sfkc=; b=QwsNhbhrooS9F1RSU+KyRg1woEUQC7Azz+vibbiBOAgwItQreobR2ZC5M6AmB1pDFQ Wq7zxVsiayedOnnabZEhOxsljDlhHfwrbOzj++PYyr3+lfTdqTcquS69J+1ql5Iiyf6+ lXZ3jW08XqKy2qOSzkFVpkh0xWnIn32hXsWrnjbSgkxMSgJqSLZdqCXkconEwPQPrGRb jmz6Z5wPVCdTJvOuPM7xyT+37GSbC3k9GA36GljSJXijW2LuWQDBBzcdX5BGmaJ22PR5 +8ngQHSi4hXUrXB/8tMjI0eFMPI16MjorkXMKZO3DRRXNctgZEmYFmlnFCbiYSUBs2+w lcLg== X-Forwarded-Encrypted: i=1; AHgh+RoTFKtEP5XVUtteff9xG0wObopTfVtFMuV9GX3nSxcBMylWPQgrRfHSWai5z2pQVO28Y5yXTe6Vlvn6twQ=@vger.kernel.org X-Gm-Message-State: AOJu0YznwCFdYLK3NicHuL9zDJMYLRxHLLWsFAJPvxKwefaFzAh7Gied mWrtH+HMZJXpfXJFUG2fKRMnYx1nRl/BmbYilSubYYMrgOqXuvKKsu5XS1zXIRniaW0= X-Gm-Gg: AR+sD11lD/7wItJaSZuXIuqD5ItSmvoaNBl9XqTodrKy6rfJmQY3sb4o5G3OTD/A2A6 LLeElv0h48U+ixGgjw3m6LahhWTdC1mzxGHkNHXLxerzE8eEJvyk9o0r3XMdpGmLg02DifpDjHF Eqt6rvvDsY4TQBNTvNYHPdDWbBqEGYXbRQOaFTVir32wvwPiNbxhSgvtiRE/mW0U5kxOlJL+2Zb TjrRYNWhIeazwuRNWlPiV0oGS8Rih0CpokG1SUH4y11dPzH0LGT+SUQo08Vd63jGCZt6giE2D7B 6h4vQT9UCtgMflpAAx+0H/C+Pnrmcc2pS5tdsLZvEmjv6yaH2gbDFLnx1zDHmmPZ+YjWuenQErX P4PSGn9bHH2PD1FgMgicvWKv/RSl5RLvXye9A5CjZu8RKjO9DM28C3G8du33CWG+u/tBq16rPbm 5P2Rzjw0wEEc5XdXDS36dnH11f4tehnCY8j2G3jbaQ3LGExBaTKPihP5E7LM69FiJyd9qK X-Received: by 2002:a05:6000:310d:b0:47f:7736:2a0c with SMTP id ffacd0b85a97d-47f77362b3bmr5262395f8f.14.1784551212769; Mon, 20 Jul 2026 05:40:12 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:544a:2852:f257:ebc5? ([2a01:e0a:106d:1080:544a:2852:f257:ebc5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63e51986sm33815224f8f.11.2026.07.20.05.40.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jul 2026 05:40:12 -0700 (PDT) Message-ID: Date: Mon, 20 Jul 2026 14:40:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH v2 3/3] drm/panel: ilitek-ili9805: make cleanup funcs void To: Michail Tatas , michael@amarulasolutions.com, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dianders@chromium.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260719190358.438699-1-michail.tatas@gmail.com> <20260719190358.438699-4-michail.tatas@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260719190358.438699-4-michail.tatas@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/19/26 21:03, Michail Tatas wrote: > Make cleanup functions return void since no one is checking > their return values > > Signed-off-by: Michail Tatas > --- > drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c > index a70b9512746a..64cfaf981e9f 100644 > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c > @@ -148,13 +148,11 @@ static int ili9805_power_on(struct ili9805 *ctx) > return 0; > } > > -static int ili9805_power_off(struct ili9805 *ctx) > +static void ili9805_power_off(struct ili9805 *ctx) > { > gpiod_set_value(ctx->reset_gpio, 0); > regulator_disable(ctx->dvdd); > regulator_disable(ctx->avdd); > - > - return 0; > } > > static int ili9805_activate(struct ili9805 *ctx) > @@ -188,15 +186,13 @@ static int ili9805_prepare(struct drm_panel *panel) > return 0; > } > > -static int ili9805_deactivate(struct ili9805 *ctx) > +static void ili9805_deactivate(struct ili9805 *ctx) > { > struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > > mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); > mipi_dsi_usleep_range(&dsi_ctx, 5000, 10000); > mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); > - > - return dsi_ctx.accum_err; > } > > static int ili9805_unprepare(struct drm_panel *panel) Reviewed-by: Neil Armstrong Thanks, Neil