From: Leon Hwang <leon.hwang@linux.dev>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
Xu Kuohai <xukuohai@huaweicloud.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Cc: Puranjay Mohan <puranjay@kernel.org>,
loongarch@lists.linux.dev, bpf@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v2] bpf: Fix unaligned interpreter panic on JIT fallback path
Date: Mon, 15 Jun 2026 09:49:22 +0800 [thread overview]
Message-ID: <f8d1b14f-e577-44bf-baf7-fe9da871889d@linux.dev> (raw)
In-Reply-To: <9c84609b-3b82-9a43-0f25-4ac632109819@loongson.cn>
On 15/6/26 09:23, Tiezhu Yang wrote:
> On 2026/6/12 下午8:37, Xu Kuohai wrote:
>> On 6/11/2026 6:12 PM, Tiezhu Yang wrote:
>>> When an architecture implements bpf_jit_inlines_helper_call(), such
>>> as LoongArch, ARM64, and RISC-V, the BPF verifier skips rewriting
>>> the helper call offset (insn->imm) during the bpf_do_misc_fixups()
>>> phase if the helper is expected to be inlined by the JIT compiler.
>>> As a result, insn->imm remains as the raw helper enum ID.
>
> ...
>
>>> +static void bpf_fixup_fallback_inline_helpers(struct
>>> bpf_verifier_env *env, struct bpf_prog *fp)
>>
>> The function name is a bit long for a static function
>
> If there are no objections, I will shorten the static function
> name to bpf_fixup_inline_helpers() in v4.
>
I think bpf_fixup_inline_helpers() is not accurate, since it is to fix
those non-inline helpers here. bpf_fixup_non_inline_helpers() is a
candidate. However, a shorter name is preferred.
Please provide changelog btw. For a single patch, you can provide
changelog here.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
Changelog:
v3 -> v4: xxx
---
kernel/bpf/core.c | 28 ++++++++++++++++++++++++++++
Thanks,
Leon
next prev parent reply other threads:[~2026-06-15 1:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 10:12 [PATCH bpf-next v2] bpf: Fix unaligned interpreter panic on JIT fallback path Tiezhu Yang
2026-06-11 10:23 ` Leon Hwang
2026-06-11 10:54 ` bot+bpf-ci
2026-06-11 11:28 ` Tiezhu Yang
2026-06-12 12:37 ` Xu Kuohai
2026-06-15 1:23 ` Tiezhu Yang
2026-06-15 1:49 ` Leon Hwang [this message]
2026-06-15 2:05 ` Tiezhu Yang
2026-06-15 2:15 ` Leon Hwang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8d1b14f-e577-44bf-baf7-fe9da871889d@linux.dev \
--to=leon.hwang@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=puranjay@kernel.org \
--cc=xukuohai@huaweicloud.com \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox