From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90A353D649A for ; Wed, 13 May 2026 14:18:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778681886; cv=none; b=TSS/aRGTAxRHkr8u9zY0/tuoNWpEBWVRpdpvr4vbHo7asu94qHTvxkYwHoiofS2p7m52Zkzvl88rl4DeJeG2ix2ZfhZobfIjQjaLElQuQGghoaBDuK/SWBjI1JmTW/XVeDENHF1t/IeFmz+mI8O8Y+d/9fquXtrHB0tBTVL1Ifw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778681886; c=relaxed/simple; bh=hLJZpGw1TT4jbenILMoumfMtn/sBA7GJejqhTn1Uk5s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QcetyhQ4axhstoEHmh1p8qRV4qEQihY8tCVgxYMAyNyu0/OBLRaUOs7zhGNzafKRsrBqzmVpK11O5tuaUyDctWhjgzV9PE/BMNqqQJuoP6q/9PQp1z02GqXu+WIsFQ9QdfXrZegMBXSoiqJRvAlcowpUpiT7q08lGc5QmaeYf40= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=HyPK3lEZ; arc=none smtp.client-ip=209.85.160.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="HyPK3lEZ" Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-439c00ed7e0so1227564fac.0 for ; Wed, 13 May 2026 07:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1778681882; x=1779286682; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CQwtfQTbtV4sWqtTbJqDHeHrOkNhE/9q+N68X0hv4io=; b=HyPK3lEZUT18/sOYIl2fVnxPdLorHCMuTfTythyKWNRRl8tXQRnkScYXsfzAoosM8l vyIM1BY72AHufRf95/12XRT2COaWyRRqYQW1MWV+1cGJivteNkvyboFh5+RRqPnSVR65 zEOL1AFpUn47VIgXaJYme0/KDU2Rsdu5QAeO7LgA5nhUQp69Ybpi0u12dWcTNKHnTLlK JXbAhW5hi+VvHDT2r1LVkB5MoEAx7V1LCQ4OzN+sMVPBLtwrZdP3OXrwS+Gkimb8Qr3c NrABzC03iyCO44F73cuXXAROZoj+6VoW3SLZbCl+8+yUh1k3bHqQEKPh8Ahzy84SayrB Tb3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778681882; x=1779286682; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CQwtfQTbtV4sWqtTbJqDHeHrOkNhE/9q+N68X0hv4io=; b=Jh6CwU1aRPbC1e8EP0rUMxxSRqUsVnmatvFGY70laI2bmEWkBVxsgp5png73Jekq+d sXgE6rcn/ayFF8oGCR3NJlXDIAu74RieA9lnwjBJOd9HxccaE+bIn7B7m+FSYAnRdRt4 rtDYDbw4h42RE1WvugXdmOgR+tfNsFisGdUlvZslBZP6G3erCdQc7JSb0EMmlJYxC5c+ R3vc3NHL4Pe67qQ8NKg68s6qAmsnjoeg6LHbDaJA3Ij8gfjB8A0VKV3TjSS6nidX7Tw6 FwKhXJq5mkT88JXG5RVT5uif+pTnT/9pYfZtdpN+KUC1rJMAJiBvm5qJXCv735nHxndT 74eQ== X-Gm-Message-State: AOJu0YxqnHcdrILGTdqJ1e0POtkVTEkWQA5dUInLWX3yZNgCJTYj8eH+ 7YPy+NXQedcrx2O9t9GgiyMdg3E/KEZx08RfnSQdXawXA6M3U6MUL7gpYPIkf7Wee4hjV9Ctjwn YY0q+ X-Gm-Gg: Acq92OHmeJKLxSC666xGwXawSb4+hGUoXl2RFsx9vcaGxeJd7n3z0C8BIfNdTr8hn1o JspyTtAzzfpxVCN5Y/A8zYEyPmd90c1MKyOKdS0aZinpEroSd0pJXiWc2rFflLWvnfGt1cofSnP 3zlgsaa6zTOcWSzJhqaGBXBiwnY5efru/56NsO0dwRDVyiqS9Xuc5goNw7Z0vl43N8zvUJp0NZj amWFKCuAMLHXFYUG23jl73Xwm47k9oh6DuPz+iJ1fBmd1YwOOrcSGKpZWj9TvSbrHETI937vP9M gfUIgYifI0cFtWGVFM1+2NRPy4HMiZ4N6O3A13P1tff+zqAi9uA7kZN9tiXz0jWrTCYctHnO+sB oGbDqH5N9TnmbO5Cm3BYK5LODUEZQ6ZhzY/3nb5wSpgrOuOSGy7IlQbZRQC7U0gx/P5iYpMyGni 2sDjQJuelilPmBiFvbptt50ggu/QZPXRnBqLzswu0GioXjlRBYxvdjta5Oyax1AFobJ0UqN3Wv8 CMFV/6cwQ== X-Received: by 2002:a05:6870:8303:b0:409:5560:72f8 with SMTP id 586e51a60fabf-439d2801e42mr1653076fac.0.1778681881754; Wed, 13 May 2026 07:18:01 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-435574490b0sm15847586fac.17.2026.05.13.07.18.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 07:18:01 -0700 (PDT) Message-ID: Date: Wed, 13 May 2026 08:18:00 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] io_uring: validate user-controlled cq.head in io_cqe_cache_refill() To: Zizhi Wo , asml.silence@gmail.com, io-uring@vger.kernel.org Cc: linux-kernel@vger.kernel.org, yangerkun@huawei.com, chengzhihao1@huawei.com References: <20260513063254.1122354-1-wozizhi@huaweicloud.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <20260513063254.1122354-1-wozizhi@huaweicloud.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/13/26 12:32 AM, Zizhi Wo wrote: > diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c > index 4ed998d60c09..92e255e9e08f 100644 > --- a/io_uring/io_uring.c > +++ b/io_uring/io_uring.c > @@ -710,11 +710,13 @@ static bool io_fill_nop_cqe(struct io_ring_ctx *ctx, unsigned int off) > * fill the cq entry > */ > bool io_cqe_cache_refill(struct io_ring_ctx *ctx, bool overflow, bool cqe32) > { > struct io_rings *rings = ctx->rings; > - unsigned int off = ctx->cached_cq_tail & (ctx->cq_entries - 1); > + unsigned int head = READ_ONCE(ctx->rings->cq.head); > + unsigned int tail = ctx->cached_cq_tail; > + unsigned int off = tail & (ctx->cq_entries - 1); > unsigned int free, queued, len; This looks wrong, as you're snapshotting 'tail' while it could get modified by if a nop fill before the refill happens. And fwiw, looks like the refill part potentially suffers from the same unsigned issue. -- Jens Axboe