From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87F484C77BA for ; Fri, 5 Jun 2026 10:50:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780656622; cv=none; b=U9JaLzyBSlFcSITP0XHhDNKJ+BEix4GjPjamk6asqItDZAAfuHfPzFvPKqLNo+R7SbLTLFkEZrRq+axNfM7TqbDzexstLc385EQr8BEoJXD28R9rX9jjWQ5SlADs5DPGX7fCuADb2eR0wPGPq/dxl+n7gq9n1QFzPBQ1cf+CQUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780656622; c=relaxed/simple; bh=Tn46f7oT2oXMsZhrMWCjRUOKDbKTRZwzTpF6O08Qjmw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VkCyzUVQIciQUrDvmz/Iu3wGj/YeJZUTYUTmYAea06ySGXzIci/EetjytWLX2o1C7dVgP8c/+KmBmNsgNcLPwhdma1crzzRNmf7/YYGlPBJhgemTw4XKeeOLBN8DGkzzWnBGu0p6gRJsQXkJ1rUw9SP9cwJ5eJHVy3HUfs6P/HQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=vpn4zRpU; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="vpn4zRpU" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id C84951A0909; Fri, 5 Jun 2026 10:50:16 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 9237E5FED1; Fri, 5 Jun 2026 10:50:16 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id AEE2E106A20FD; Fri, 5 Jun 2026 12:50:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1780656615; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=+nOY3W2L3VteDfAdwfnzKZgeh7JFLl7CeGAntoZOhWU=; b=vpn4zRpUDXc7wnhalcjLHM6UMh3KrBZDfovtVa9U3V+t5K+m8HzOPRSrDUAe5rc2AviO3k dXSdf8QdqoE66xdBcbFsbyIW3MUOkp5JNaxAIi/d6eOmm9FS6iuCz87+HThMHnTFkYblqU pZPkiCrZEYidZpbffOqWF05oOXesJ9sKjPsgEXudDpUDqGNvMRiMHG4tzxis9FXB7a4mUB AwoJf6uTvZ1l1Myy7YcVoQ2e5Xg9/8OR4l9PeNfWQzFfX7SVDLGEqIaZVufRqmQANjgsXi oZCdt79e1pSETkSSuvFHnY4RrwaqjR0n2Oj6x6ckCINVWUaGQT+G7Dd+qadGPA== Message-ID: Date: Fri, 5 Jun 2026 12:50:10 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v1 1/5] net: phy: realtek: add support for dummy phy To: Javen , Andrew Lunn Cc: "hkallweit1@gmail.com" , "nic_swsd@realtek.com" , "andrew+netdev@lunn.ch" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "horms@kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20260603065916.334-1-javen_xu@realsil.com.cn> <20260603065916.334-2-javen_xu@realsil.com.cn> <7496c873-fee7-4584-ad70-4315d7b94f8f@bootlin.com> <0bc2ae0e-316c-447e-9098-f18f4b491328@bootlin.com> <7c35fa5bb5f24afdb42e2d45a4e559c3@realsil.com.cn> Content-Language: en-US From: Maxime Chevallier In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Last-TLS-Session-Version: TLSv1.3 Hi, On 6/5/26 11:43, Javen wrote: > > Hi, > >>> You are exactly right. The PHY doesn't actually exist; what we have is >>> an internal PCS. >> >> ... >> >>> I actually tried to migrate it to >>> phylink before. However, the current driver codebase is deeply coupled >>> with tp->phydev in many places. Decoupling it may introduce bugs for >>> numerous existing devices. Therefore, I want to try to expose the >>> internal PCS as a dummy PHY device. >> >> Architecturally, you are going down a dead end. You really should be using >> phylink. >> >> I don't see anything too scary with tp->phydev in the driver. Are there parts >> you think are going to be a problem with phylink? >> >> Andrew > > Thanks for your suggestion. > > Since I am not very familiar with phylink, so I may have been too conservative about the migration. I have prepared a version using phylink and will submit it for review. > > Any comments or suggestions would be very helpful. We can help reviewing this, indeed :) You should be able to follow the porting guide here : https://docs.kernel.org/networking/sfp-phylink.html It was updated not too long ago :) Maxime > > Thanks, > BRs, > Javen