From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74B15C83000 for ; Tue, 28 Apr 2020 22:15:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5B0932072A for ; Tue, 28 Apr 2020 22:15:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726672AbgD1WPt (ORCPT ); Tue, 28 Apr 2020 18:15:49 -0400 Received: from mga18.intel.com ([134.134.136.126]:26457 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbgD1WPt (ORCPT ); Tue, 28 Apr 2020 18:15:49 -0400 IronPort-SDR: QXDiYcWFGOR6StZHNbw/Rqk1qJoNGY6rWV+iMOFpuFrsF2vygLmKfzLza9scJvXtyD6UxB8ny6 4npapGxDhJGQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2020 15:15:48 -0700 IronPort-SDR: eRV6iaBNmKKuN9h0cUBLeme0Sl6sh7Bxij2kPN/7HSwyuHGDVtHBvl9TUo5UT2VOlL6q4wkR8Y IizTU+otdEww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,328,1583222400"; d="scan'208";a="249293993" Received: from asehgal-mobl.amr.corp.intel.com (HELO [10.254.29.183]) ([10.254.29.183]) by fmsmga008.fm.intel.com with ESMTP; 28 Apr 2020 15:15:41 -0700 Subject: Re: [PATCH] ASoC: SOF: sort out Kconfig, again To: Arnd Bergmann Cc: Stephen Rothwell , ALSA Development Mailing List , Fabio Estevam , "linux-kernel@vger.kernel.org" , Kai Vehmanen , Shawn Guo , Sascha Hauer , Takashi Iwai , YueHaibing , Liam Girdwood , Krzysztof Kozlowski , Ranjani Sridharan , Mark Brown , NXP Linux Team , Pengutronix Kernel Team , Daniel Baluta , Linux ARM , sound-open-firmware@alsa-project.org References: <20200428212752.2901778-1-arnd@arndb.de> <6b39fbba-c65d-2c02-14bf-11c2d00547af@linux.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Tue, 28 Apr 2020 17:15:40 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Thanks Arnd, do you mind sharing your config? > > https://pastebin.com/HRX5xi3R will give it a try, thanks! >> We noticed last week that >> there's a depend/select confusion might be simpler to fix, see >> https://github.com/thesofproject/linux/pull/2047/commits >> >> If I look at the first line I see a IMX_DSP=n which looks exactly like >> what we wanted to fix. > > Yes, I think that fix addresses the build warning as well, but looking > more closely I don't think it's what you want: If you do this on > a config that has the IMX_DSP disabled, it would appear to the > user that you have enabled the drivers, but the actual code is still > disabled. Are you sure? we added a select IMX_DSP, so not sure how it can be disabled?