From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CABE176AA1 for ; Mon, 4 Nov 2024 08:30:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730709047; cv=none; b=ktSotepbDio4TfTE3IFLn/qIJr4uL9CgarCM70fjMtsyKwAO4/FPFGZAI8s4dpIKtxRAKk7TB0CygU+AO7DeE2Otfp7Yg6WjoeXlwEN3DLVyE2TeQDFb8dcZDQ84WPMMd3h/BEw740WsMtIwGxbFchy+Q1qB7KmbPshU5ScaZn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730709047; c=relaxed/simple; bh=5VkJOu+g5b0qKiJ1jIlwSX5lX2+9tMD4oEX3nkRSlOU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eOGtKn9lKbtVHIIup4MsOTtuQKgwZT3k7zAAQqR//80lE79FWIEcuDZQuJg6Fo0Ry5aFPtDUkomRNkt4sDsyo3Qg3lmuU0w4OmLHhF0BsuAGs9kwmlx8FX267YG0sLgbZKpcfy2lRbHqFjTfro7b52jieRApERxsHpFlaHTU2Zg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=TwkDpXXG; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="TwkDpXXG" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4316cce103dso48171895e9.3 for ; Mon, 04 Nov 2024 00:30:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1730709044; x=1731313844; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1QGb6/0TsMbjRxg1vp5PNXgU38SBTpwljeMmmAjykPk=; b=TwkDpXXGoOqJEt2O0sXuXl+/xTKmFcyjJ+YtjXH3dVO9AdT+gnoD/KrdCM0B6ihWXW S23CNdLqaKDfJ+SxQOEOOv7h7VCh6qevuiQuLcg909kOhsb9ZYDfseh3aqm1vbmpeBRg J9LN16v7ShJQhvEOiGmX6Ywd9cf53A4b9W4oMdywVq1k82+qR1F5lhoa7JP8vnK5Q+yC pAHO5byFbE527TS75/cu2hVvb9XGYacBIja4ootgps65m/e70Qxlj+6mVl58Xp6bfXsq ORafEloXj89Sct/oprxLWPHPbXVTxTbDVq1KeX4MjKmi95RMsc9l/Mtr6+3rlyUZre50 1KJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730709044; x=1731313844; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1QGb6/0TsMbjRxg1vp5PNXgU38SBTpwljeMmmAjykPk=; b=wO+wK/Muh+sy9TnICzPS/ZyC+O89inQII6o8o91M4s1y5Sd6gSmybSraBwg00zIZ5/ msMfC4dK3elHmCYB6i8a18hVRx0pLvUdJCRuc5ukLxtKuqUERFi/c3hjGp+2T/7JYadt m6n63TUbpIHq7cA50WZFkNpC91DWp96iPjxUBCk3HQdSr/h6xWn/9KN2NVFGfL4GZgj5 rhBLu3nDt78bbAaSTH0dKwjMoQLyHMgyx0c6v3qH/zUqB1rEim7swp17t67+Ec2RZLzH VvRKb3Iz0+OFdLUacSeNkw7nFLL2AMDqRslzYfF0q88/Lxn3LRbHrfxdQRFG4bfKhGKF KD9w== X-Forwarded-Encrypted: i=1; AJvYcCW019K0Z4vbubaiqIqezHuqwuJlId9n0uFNp2PVPr6ePfUrjZIZy1rv22HKGdip3/9fUTM9BMsRz/lg2CI=@vger.kernel.org X-Gm-Message-State: AOJu0YztAVMEIye2CVphRkouCTemv+Y6qgsN/WYpHMYWIqbTjbZ0mcnc cO17QNV134/Lq21q3mgnK5ifIuzPuAsHiv/56GkEYM5mG/7P7KQoV/6SUi2IQ8c= X-Google-Smtp-Source: AGHT+IFVV5wGFTKKBwe9YF3sHy2XdahxtRxXMb+KfShZQJ9smORqFjeuuKbIuJHbFCl9WsNYnco+Xw== X-Received: by 2002:a05:600c:3c83:b0:431:24c3:dbaa with SMTP id 5b1f17b1804b1-43283242aefmr123723985e9.2.1730709043788; Mon, 04 Nov 2024 00:30:43 -0800 (PST) Received: from [192.168.1.94] (56.31.102.84.rev.sfr.net. [84.102.31.56]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-431bd8e9145sm175101275e9.1.2024.11.04.00.30.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Nov 2024 00:30:43 -0800 (PST) Message-ID: Date: Mon, 4 Nov 2024 09:30:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] counter: ti-ecap-capture: Add check for clk_enable() To: Jiasheng Jiang , vigneshr@ti.com, wbg@kernel.org, gregkh@linuxfoundation.org Cc: linux-iio@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241103213910.31976-1-jiashengjiangcool@gmail.com> Content-Language: en-US From: Julien Panis In-Reply-To: <20241103213910.31976-1-jiashengjiangcool@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/3/24 22:39, Jiasheng Jiang wrote: > Add check for the return value of clk_enable() in order to catch the > potential exception. > > Fixes: 4e2f42aa00b6 ("counter: ti-ecap-capture: capture driver support for ECAP") > Signed-off-by: Jiasheng Jiang > --- > drivers/counter/ti-ecap-capture.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/counter/ti-ecap-capture.c b/drivers/counter/ti-ecap-capture.c > index 675447315caf..30a269fa5da0 100644 > --- a/drivers/counter/ti-ecap-capture.c > +++ b/drivers/counter/ti-ecap-capture.c > @@ -574,8 +574,11 @@ static int ecap_cnt_resume(struct device *dev) > { > struct counter_device *counter_dev = dev_get_drvdata(dev); > struct ecap_cnt_dev *ecap_dev = counter_priv(counter_dev); > + int ret; > > - clk_enable(ecap_dev->clk); > + ret = clk_enable(ecap_dev->clk); > + if (ret) > + return ret; > > ecap_cnt_capture_set_evmode(counter_dev, ecap_dev->pm_ctx.ev_mode); > Reviewed-by: Julien Panis