From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: John Garry <john.g.garry@oracle.com>,
axboe@kernel.dk, mst@redhat.com, jasowang@redhat.com,
xuanzhuo@linux.alibaba.com, eperezma@redhat.com,
pbonzini@redhat.com, stefanha@redhat.com, hare@suse.de,
kbusch@kernel.org, hch@lst.de
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux.dev
Subject: Re: [PATCH v2 3/5] null_blk: Don't bother validating blocksize
Date: Tue, 9 Jul 2024 02:12:50 +0200 [thread overview]
Message-ID: <f92269eb-3664-42ae-83a7-8eb0a3af3f08@linux.dev> (raw)
In-Reply-To: <20240708091651.177447-4-john.g.garry@oracle.com>
在 2024/7/8 11:16, John Garry 写道:
> The block queue limits validation does this for us now.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: John Garry <john.g.garry@oracle.com>
> ---
> drivers/block/null_blk/main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
> index 9d0f6da77601..2f0431e42c49 100644
> --- a/drivers/block/null_blk/main.c
> +++ b/drivers/block/null_blk/main.c
> @@ -1831,9 +1831,6 @@ static int null_validate_conf(struct nullb_device *dev)
> dev->queue_mode = NULL_Q_MQ;
> }
>
> - if (blk_validate_block_size(dev->blocksize))
> - return -EINVAL;
Reviewed-by: Zhu Yanjun <yanjun.zhu@linux.dev>
Thanks,
Zhu Yanjun
> -
> if (dev->use_per_node_hctx) {
> if (dev->submit_queues != nr_online_nodes)
> dev->submit_queues = nr_online_nodes;
next prev parent reply other threads:[~2024-07-09 0:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-08 9:16 [PATCH v2 0/5] Validate logical block size in blk_validate_limits() John Garry
2024-07-08 9:16 ` [PATCH v2 1/5] virtio_blk: Fix default logical block size fallback John Garry
2024-07-08 9:16 ` [PATCH v2 2/5] block: Validate logical block size in blk_validate_limits() John Garry
2024-07-09 5:38 ` Damien Le Moal
2024-07-08 9:16 ` [PATCH v2 3/5] null_blk: Don't bother validating blocksize John Garry
2024-07-09 0:12 ` Zhu Yanjun [this message]
2024-07-09 5:39 ` Damien Le Moal
2024-07-08 9:16 ` [PATCH v2 4/5] virtio_blk: " John Garry
2024-07-09 5:39 ` Damien Le Moal
2024-07-08 9:16 ` [PATCH v2 5/5] loop: " John Garry
2024-07-09 5:39 ` Damien Le Moal
2024-07-09 6:01 ` [PATCH v2 0/5] Validate logical block size in blk_validate_limits() Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f92269eb-3664-42ae-83a7-8eb0a3af3f08@linux.dev \
--to=yanjun.zhu@linux.dev \
--cc=axboe@kernel.dk \
--cc=eperezma@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jasowang@redhat.com \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox