Re: [PATCH v4 1/6] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface bindings

Krzysztof Kozlowski
2023-01-12T08:11:46Z

On 12/01/2023 03:05, yuji2.ishikawa@toshiba.co.jp wrote:
>>>> Compatible must be specific. You called your SoC visconti5, didn't you?
>>>>
>>>
>>> The Video Input Interface hardware is likely to be used at future SoCs
>>> of Visconti Architecture.
>>> Does compatible have to be specific to SoC's model name rather than
>>> architecture name?
>>
>> Compatibles should always be specific to SoC model name. Adding more generic
>> family fallback is also good idea when it is applicable.
>>
>
> I'll update the compatible to "toshiba,visconti5-viif".
> I'll consider adding generic version "toshiba,visconti-viif" when a successor SoC gets available.

Are you sure? You will have to wait at least one cycle between DTS and
driver change, due to ABI break of DTB users.

Best regards,
Krzysztof