From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B4B63CCFB4 for ; Tue, 25 Aug 2026 06:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787640018; cv=none; b=WAS8sTgu3SayBu3dUBeX6RtclZbowTgKkgrQR7LosD5Uuhb5irGR5lVFa/3W3XosBnHU6WEGhB6cR1MVTRFDo/gZmjH9G0gSVuvWw6WkzJ4vu5S5cI2QXQ6RnXm2+h3I0cCAIhMDnMBdGPMc2q2z9340uXajMp2kR59H4lXqmEw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787640018; c=relaxed/simple; bh=EDRHoaCv9VQVo5toCiQKoKX7K3V/kkCTGPiG63roSvg=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=e8SJRZvyTGuYDYXEa2WwUHVm6+xhY5902KLWgCZyy2wzr/jvqCE0N9RI1ZUO9cGsMm+mllRiD6rgMb+54Y3qcUgVGR2z5x3m68d+IQk+GiccNjdlSToXMUnxAWwaLZuGy0X8ooxGgk1FMT9s/KkGYNMzi5j0Hxbf3MNXiLU2h+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V4vFO5vY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V4vFO5vY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA3F51F000E9; Tue, 25 Aug 2026 06:40:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787640016; bh=/Q+NpiiFl2aNWbg70O8DFOTdkeOFE8QEIeXcleG8hUg=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=V4vFO5vY/JExdmr6VRZcAnu8Mp89x2jtpUxcjLweJyKa8W6PjFrWLxaPdF6tR6o07 lyKw6q1EQj2gMvNsb6f4H+RAB3iXdqriva4/UoVYDm1p8RHHjcgCpJU694EoUkGHcU bIeVV1pRvDSaBwVlnhILgNUeO982jKlzRT7/c8P5W5xcgUEp/cb40rJRKVTmhEbv6M YxTtsztwrHw/LTQ+d2dEmAa8/KApdy3bgqkP73yXc9TjEyjNQpWs6sCX6pFX926CAI vP0mPoyL/7Nh0mWv/upQjsvPHZsHKD+4IoEZkssz1xwLpGsxWP2H7zW66K+xko4WGr uSceC7hIV7uCg== Message-ID: Date: Tue, 25 Aug 2026 14:40:14 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, Jaegeuk Kim , qiwenjie@xiaomi.com, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v2 07/12] f2fs: cache: use node cache To: Wenjie Qi References: <20260824134731.3704352-1-chao@kernel.org> <20260824134731.3704352-8-chao@kernel.org> <20260825054331.400340-1-qiwenjie@xiaomi.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260825054331.400340-1-qiwenjie@xiaomi.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/25/26 13:43, Wenjie Qi wrote: > Hi Chao, > >> if (!f2fs_clear_cache_dirty(entry)) >> goto continue_unlock; >> >> if (!__write_node_cache(entry, ...)) >> ... > > and in `__write_node_cache()`: > >> if (unlikely(ni.blk_addr == NULL_ADDR)) { >> f2fs_cache_clear_uptodate(entry); >> dec_page_count(sbi, F2FS_DIRTY_NODES); >> ... >> return true; >> } > > `f2fs_clear_cache_dirty()` clears the entry state bit but leaves the DIRTY > radix tag for the writeback transition. The `NULL_ADDR` return does not reach > that transition, while it clears UPTODATE and decrements the dirty-node count. > > What clears the DIRTY radix tag when this already-truncated path returns? Hmm, Actually, I don't change the logic here, just change the API, I can take a look original logic a bit later. Thanks,