From: Florian Fainelli <florian.fainelli@broadcom.com>
To: Doug Berger <opendmb@gmail.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: brcmstb-waketimer: support level alarm_irq
Date: Thu, 31 Aug 2023 16:27:58 -0700 [thread overview]
Message-ID: <f96930c8-4ee4-398d-3930-cf25deb83d2a@broadcom.com> (raw)
In-Reply-To: <20230830224747.1663044-1-opendmb@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 793 bytes --]
On 8/30/23 15:47, Doug Berger wrote:
> Some devices (e.g. BCM72112) use an alarm_irq interrupt that is
> connected to a level interrupt controller rather than an edge
> interrupt controller. In this case, the interrupt cannot be left
> enabled by the irq handler while preserving the hardware wake-up
> signal on wake capable devices or an interrupt storm will occur.
>
> The alarm_expired flag is introduced to allow the disabling of
> the interrupt when an alarm expires and to support balancing the
> calls to disable_irq() and enable_irq() in accordance with the
> existing design.
>
> Fixes: 24304a87158a ("rtc: brcmstb-waketimer: allow use as non-wake alarm")
> Signed-off-by: Doug Berger <opendmb@gmail.com>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
next prev parent reply other threads:[~2023-08-31 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-30 22:47 [PATCH] rtc: brcmstb-waketimer: support level alarm_irq Doug Berger
2023-08-31 23:27 ` Florian Fainelli [this message]
2023-09-15 18:50 ` Florian Fainelli
2023-10-01 22:15 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f96930c8-4ee4-398d-3930-cf25deb83d2a@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=opendmb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox