From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Fuqian Huang <huangfq.daxian@gmail.com>
Cc: Seth Heasley <seth.heasley@intel.com>,
Neil Horman <nhorman@tuxdriver.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 08/27] i2c: busses: remove memset after dmam_alloc_coherent
Date: Fri, 28 Jun 2019 09:22:31 +0300 [thread overview]
Message-ID: <f97d130f-0906-05cb-6f08-bb84bf32ff02@linux.intel.com> (raw)
In-Reply-To: <20190628024711.15203-1-huangfq.daxian@gmail.com>
Hi
On 6/28/19 5:47 AM, Fuqian Huang wrote:
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dmam_alloc_coherent has already zeroed the memory.
> So memset is not needed.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> drivers/i2c/busses/i2c-ismt.c | 2 --
> 1 file changed, 2 deletions(-)
>
It would be better to refer actual commit or commits that implement that
zeroing rather than merge point in commit log if possible.
At quick look commit 518a2f1925c3 ("dma-mapping: zero memory returned
from dma_alloc_*") is the one but I'm not really an expert here to say
is that alone enough.
--
Jarkko
next prev parent reply other threads:[~2019-06-28 6:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 2:47 [PATCH v2 08/27] i2c: busses: remove memset after dmam_alloc_coherent Fuqian Huang
2019-06-28 6:22 ` Jarkko Nikula [this message]
2019-06-29 11:12 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f97d130f-0906-05cb-6f08-bb84bf32ff02@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=huangfq.daxian@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=seth.heasley@intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox