From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754353AbdDQPPq (ORCPT ); Mon, 17 Apr 2017 11:15:46 -0400 Received: from mout.web.de ([212.227.17.12]:51205 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754025AbdDQPPn (ORCPT ); Mon, 17 Apr 2017 11:15:43 -0400 Subject: [PATCH 05/25] net: mvpp2: Use kmalloc_array() in mvpp2_txq_init() From: SF Markus Elfring To: netdev@vger.kernel.org, "David S. Miller" , Florian Fainelli , Jarod Wilson , Jisheng Zhang , Mirko Lindner , Philippe Reynes , Russell King , Sergei Shtylyov , Stephen Hemminger , Thomas Petazzoni Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Mon, 17 Apr 2017 17:15:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:W9MZD98t+i8xjTx2/CmMg5tIBeBXAAR0ky90gDfMdMnak1PUydd yX1CAl8X5FouwkRQlMknJIJpu5AW+VHzMmkvYm7Lx+MKOjGr08pnDgK6BKECTca6ATVjxtY gmm8iykBDxmQcp3cIveT228LWn6c8q3iZkOVUQmJq0QuuuelTCUtcK2dT62fyMBz8jEFAuC 2GSRVl3oAP7eg4Zld/9hA== X-UI-Out-Filterresults: notjunk:1;V01:K0:diRPMy01i2M=:14Dnp5NAXqMGrBio2Wk8SC AValJsEY9Nw+sqW/t1Q4iU2gNwUTds5qxm7W9eEy1A4ZIRVu5kZyrsq+dv2f0Z/FEKt9OJjby WNKryYknEweybh3ZB3SoLBTrN4doa7QRu5stpjRL5NdfK8zs9O5Z9keXvVGb89BAvQLYIt0vl tU48Lym6Fk3ZZT3C9mgEWvXX7kGgw0h0rfZWidqgk9zNxjQlhpMAmt4jVsl2NKFq1fQTdgYLA xzZoy/7Ifn4hghQlAQNJgHJwTlGh/+wmk/s8ZLGzCyzB+mAv/Obu5gzCWgF9necSQdhJ4BriB TO6VHtRwNdRRJmDzUolrt5Wuy35bLZvZWd4kbpflzc7wSaQHkVWA246npgdTcddF3AVq0kg/0 qkSPyxd1a0fERLZLY+i0/5mtRzNQkj3jcj9VhPWRrdzBTK6NXPCMq7IxLlJWbmZfv5nuYajaW jjk7eox6oqrgmigbYV5O9Xua8/fGHB5zAe91oiYH13XReF36VCKdVv1o1ffVko5NovpvsP759 TLppaUEaSVwdqth1veCNK/G3o+J0/g3qHDRBObX31KYaVcRF67TG0KY1oH7y6Gh078JxYnUS+ PkusqymXI4tsb+ti6zA3fONPNEE6iM+N4n+ile9brU6y5l7wev+Y4gsNb5gbd/CNbjwgdNkq7 Z+cv9YE9Ly0B+YYFTopU5u/ya+wK8eEFrIWY0TbBG/oJdJHHZMFtNh+aTozOIKbwC28ZzOSJr I250xf+p15gDDZcrvJklZ69n5YSgLG3LIpSw8JQiNrGNUm7Ae0gZGlvGzSUXPXHexMhZ+MPzk koHfpN7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 17 Apr 2017 08:09:07 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index af5bfa13d976..a86d9111c476 100644 --- a/drivers/net/ethernet/marvell/mvpp2.c +++ b/drivers/net/ethernet/marvell/mvpp2.c @@ -5083,9 +5083,9 @@ static int mvpp2_txq_init(struct mvpp2_port *port, for_each_present_cpu(cpu) { txq_pcpu = per_cpu_ptr(txq->pcpu, cpu); txq_pcpu->size = txq->size; - txq_pcpu->buffs = kmalloc(txq_pcpu->size * - sizeof(struct mvpp2_txq_pcpu_buf), - GFP_KERNEL); + txq_pcpu->buffs = kmalloc_array(txq_pcpu->size, + sizeof(*txq_pcpu->buffs), + GFP_KERNEL); if (!txq_pcpu->buffs) goto error; -- 2.12.2