From: Markus Elfring <Markus.Elfring@web.de>
To: Navid Emamdoost <navid.emamdoost@gmail.com>,
dri-devel@lists.freedesktop.org
Cc: Navid Emamdoost <emamd001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
Stephen McCamant <smccaman@umn.edu>, Qiushi Wu <wu000273@umn.edu>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Rob Herring <robh@kernel.org>,
Steven Price <steven.price@arm.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit
Date: Sun, 14 Jun 2020 13:31:09 +0200 [thread overview]
Message-ID: <f99b8509-c2b9-e96a-3cb6-5e693afa138a@web.de> (raw)
> in panfrost_job_hw_submit, …
* Can the term “reference count” become relevant also for this commit message
besides other possible adjustments?
* Would you like to add the tag “Fixes”?
…
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
…
> @@ -184,6 +183,9 @@ static void panfrost_job_hw_submit(struct panfrost_job *job, int js)
> job, js, jc_head);
>
> job_write(pfdev, JS_COMMAND_NEXT(js), JS_COMMAND_START);
> +out:
> + pm_runtime_put_sync_autosuspend(pfdev->dev);
> + return;
> }
…
Perhaps use the label “put_sync” instead?
Regards,
Markus
next reply other threads:[~2020-06-14 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-14 11:31 Markus Elfring [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-14 11:31 [PATCH] drm/panfrost: fix ref count leak in panfrost_job_hw_submit Markus Elfring
2020-06-14 11:31 Markus Elfring
2020-06-14 6:27 Navid Emamdoost
2020-07-07 2:31 ` Alyssa Rosenzweig
2020-07-09 15:44 ` Rob Herring
2020-07-09 15:59 ` Steven Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f99b8509-c2b9-e96a-3cb6-5e693afa138a@web.de \
--to=markus.elfring@web.de \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emamd001@umn.edu \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=navid.emamdoost@gmail.com \
--cc=robh@kernel.org \
--cc=smccaman@umn.edu \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
--cc=wu000273@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox