From: Shuah Khan <skhan@linuxfoundation.org>
To: Xi Ruoyao <xry111@xry111.site>, Fangrui Song <maskray@google.com>,
Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests/vDSO: support DT_GNU_HASH
Date: Tue, 27 Aug 2024 07:12:35 -0600 [thread overview]
Message-ID: <f9e2d443-9d20-498a-a2d7-fa2e13fbb3f9@linuxfoundation.org> (raw)
In-Reply-To: <29c04b2f2b35588824447f4c91d3c89ed3ed8895.camel@xry111.site>
On 8/26/24 00:07, Xi Ruoyao wrote:
> On Wed, 2024-08-14 at 20:26 -0700, Fangrui Song wrote:
>> glibc added support for DT_GNU_HASH in 2006 and DT_HASH has been
>> obsoleted for more than one decade in many Linux distributions.
>>
>> Many vDSOs support DT_GNU_HASH. This patch adds selftests support.
>>
>> Signed-off-by: Fangrui Song <maskray@google.com>
>> ---
>
> Ping.
>
> Some context: I'd change LoongArch vDSO to use the toolchain default
> instead of forcing DT_HASH (note that LoongArch is launched decades
> after all major distros switched to DT_GNU_HASH), but without the
> selftest support we'll lose test coverage.
>
> And now ARM64 has already lost test coverage after commit 48f6430505c0.
>
I am seeing several checkpatch errors - please fix them and send me v2.
thanks,
-- Shuah
next prev parent reply other threads:[~2024-08-27 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 3:26 [PATCH] selftests/vDSO: support DT_GNU_HASH Fangrui Song
2024-08-15 5:39 ` Xi Ruoyao
2024-08-26 6:07 ` Xi Ruoyao
2024-08-27 13:12 ` Shuah Khan [this message]
2024-08-27 13:37 ` Fangrui Song
2024-09-03 21:24 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9e2d443-9d20-498a-a2d7-fa2e13fbb3f9@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maskray@google.com \
--cc=shuah@kernel.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox