public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: angkery <angkery@163.com>
Cc: axboe@kernel.dk, linux-ide@vger.kernel.org,
	linux-kernel@vger.kernel.org, Junlin Yang <yangjunlin@yulong.com>
Subject: Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero
Date: Sat, 10 Apr 2021 11:46:45 +0300	[thread overview]
Message-ID: <f9ea1536-6cfe-29fe-1ecd-95d0f68d3a85@gmail.com> (raw)
In-Reply-To: <20210410073814.00003b86.angkery@163.com>

On 10.04.2021 2:38, angkery wrote:
> On Fri, 9 Apr 2021 20:02:56 +0300
> Sergei Shtylyov <sergei.shtylyov@gmail.com> wrote:
> 
>> On 4/9/21 7:49 PM, Sergei Shtylyov wrote:
>>
>>>> From: Junlin Yang <yangjunlin@yulong.com>
>>>>
>>>> The return from the call to platform_get_irq() is int, it can be
>>>> a negative error code, however this is being assigned to an
>>>> unsigned int variable 'irq', so making 'irq' an int, and change
>>>> the position to keep the code format.
>>>>
>>>> ./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
>>>> WARNING: Unsigned expression compared with zero: irq > 0
>>>
>>>     I'd understand < 0... but > 0? What tool warned about this issue?
>>>    
>>>> yes, by coccicheck, i will update commits information.

    Thanks!
    Yet, looking at your subject, the above should read irq < 0, not > 0.

>>>> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>



      reply	other threads:[~2021-04-10  8:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 13:54 [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero angkery
2021-04-09 14:02 ` Jens Axboe
2021-04-09 16:49 ` Sergei Shtylyov
2021-04-09 17:02   ` Sergei Shtylyov
2021-04-09 23:38     ` angkery
2021-04-10  8:46       ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9ea1536-6cfe-29fe-1ecd-95d0f68d3a85@gmail.com \
    --to=sergei.shtylyov@gmail.com \
    --cc=angkery@163.com \
    --cc=axboe@kernel.dk \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yangjunlin@yulong.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox