From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757228AbcIGLTt (ORCPT <rfc822;w@1wt.eu>);
        Wed, 7 Sep 2016 07:19:49 -0400
Received: from mout.web.de ([217.72.192.78]:65178 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1756908AbcIGLTs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 7 Sep 2016 07:19:48 -0400
Subject: Re: x86-ksysfs: Use kmalloc_array() in create_setup_data_nodes()
To: Paolo Bonzini <pbonzini@redhat.com>
References: <3b21b2d7-9856-009c-9bd1-3a76a83bc7fc@users.sourceforge.net>
 <CAGXu5jLSsU+daPP=uX+3T02RkTFguG1rtemOF-7Py_Fi=qYP6A@mail.gmail.com>
 <e24dae2d-b55a-d90a-9934-080e6165802b@users.sourceforge.net>
 <f1caa945-b808-f6b5-6047-35c43330431f@redhat.com>
Cc: Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@redhat.com>,
        "x86@kernel.org" <x86@kernel.org>, Dave Young <dyoung@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Matt Fleming <matt.fleming@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <f9edcf05-482e-dfbb-b661-c070ee1debf4@users.sourceforge.net>
Date: Wed, 7 Sep 2016 13:17:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <f1caa945-b808-f6b5-6047-35c43330431f@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:YHkHhLoFBXeNNKXigjIEySRpLkywfzc18FVKPkaTo6q4WtBLnfc
 57B7woI/cUTolZaDWrelVaQHZycQZBXWTsgPMNOEVcR/cPQ7d/Tsmkva55TY38g164hfqtY
 P8dZJ5lAazUhVgilwD1VyHyiCHRnWOm+g9CS0PNMJT2C/mdzqys2CNkF0IGsVxkbxSqwTTF
 kCIjVn1TPp9Iq/yHpfspw==
X-UI-Out-Filterresults: notjunk:1;V01:K0:Z/9rSLIqbKM=:jISXTyCu+s2vrHSECIdcRo
 UlJ7sXXF2H/22ZMUBJFbCc1yea25Z3npHV+cdCCoD6+zlkF0XzMkokuDfYbJUHw3SKjzEUmEF
 7G0J0qgB6Uytp1iYwVxOOGyYa4bGkf7fDmspVnA16YQGr8HXV/HpC8G3vDW5IfH0izxxqCw5K
 ITWesOTLUAMcWteDw+T32d7tFwrrg55lkwAAOwPoKEg9ddtolpDyhlaqb9YD22wr++WKnUBLF
 G4vH135qB+s0p8v2tQp+cFp/l9CQRWlmgl6/bd3hVsdw8qsOlqW6TKql8HYRTfG9OJkW/lmSk
 Odpy7T1vhQwBU5myv4aoXIKHNxgQxsAiIfuJuUDKa4ha+Gp8eSh20r4FCjdG35eITyKTS/wtK
 t1galrTp1jxLNcCyHFJhl6536dZGC3WWOoKNmudxEoCDItSPd3Z1TL8/PIE0c7dffChTrHUxf
 d3YWmDjxyELv03sH/Y/HZSvcKWcJr65jI7f6gxmVWtvWr573K1VTPCRIo8UD8LRz7BaiBLp7C
 lBJgVajgyo4P+B1qNBTm2PULCi+b4VN5EsETG0XSPDl8ku4gK0YWMxZeSB/2y3Ik3re1/iS4A
 HCCykYYKv7mAZl+7mOMqdzVqATCSj6mY0F2OBcHduRTx5cfCfo6xQt3+t19UUoPw4WIhFCVtE
 Mw51N2jt/sHaOzuABv7Zg7kCyporh+RcBFl+wyC6RAIEMKZ8oGubq+wAj+Nav9u0dcz9H7IzW
 7LXCMQdM6fsHQ16ArlA2qj36+U10slo+ryMeRACs1TH7FiXTbzCEMIEYyyatOkdZka5JnHd27
 a4ME1F6
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> Are you looking for further possibilities to improve the involved
>> source code search patterns?
> 
> Why are you not answering the simple question that was asked?

I find that I answered it to some degree.

It can be that you do not really like the kind of answer that I chose
a moment ago.
But I guess that a more pleasing (and complete) answer can become
another software development challenge as you might know already.

Would the following script (for the semantic patch language)
be useful enough for further development considerations?

usage_of_kmalloc_array1-excerpt2.cocci:
@replacement2@
expression count, pointer, target;
@@
 target =
-         kmalloc(sizeof(*pointer) * (count)
+         kmalloc_array(count, sizeof(*pointer)
                        , ...);

Regards,
Markus