From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jeremy Kerr <jk@ozlabs.org>, Ryan Chen <ryan_chen@aspeedtech.com>
Cc: "robh@kernel.org" <robh@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"andi.shyti@kernel.org" <andi.shyti@kernel.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
Mo Elbadry <elbadrym@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v16 1/3] dt-bindings: i2c: aspeed: support for AST2600-i2cv2
Date: Wed, 10 Sep 2025 09:44:00 +0200 [thread overview]
Message-ID: <f9fc4b59-bdcd-4983-b7c2-0fec94e62176@kernel.org> (raw)
In-Reply-To: <44ef5c93448a3625fcfd003b47a516e8ba795b62.camel@ozlabs.org>
On 10/09/2025 09:25, Jeremy Kerr wrote:
> Hi Ryan & Krzysztof,
>
> [my response is intended to make progress on the newer v18 submission,
> but we still have this item from v16 to resolve, hence picking up this
> thread]
>
>> Your compatible already expressed that there are two interfaces, so
>> your drivers can just choose whichever they want. If you need to toggle a
>> bit in system controller, it is fine. If you need different compatible,
>> then that's a NAK.
You trimmed response and brought some very old thread which does not
exist in my inbox.
I have absolutely no clue what this refers to.
>
> I think the mention of "two register interfaces" is a bit misleading
> here; it implies that it's just two interfaces to the same hardware.
>
> From reading between the lines on the datasheet, it seems that this is
> two completely separate IP cores, that:
>
> * are mapped to the same MMIO space; but
> * both happen to be I2C controllers.
>
> - where the single "global register" (which you mention above) provides
> the facility to mux the MMIO mapping between the two. Some versions of
> the overall SoC have only the old core, some have only the new, and some
> have both, selectable via this register.
>
> Ryan, can you confirm whether this is the case?
>
> Given there are actual behavioural differences between the two
> peripherals - beyond just the register set - that would seem to indicate
> separate binding types (+ a syscon mux control) to me, but I'm keen to
> hear any other options.
>
> Krzysztof, if that is the case, any thoughts on the representation of
> separate bindings?
I have no clue what is this about.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-10 7:44 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 5:59 [PATCH v16 0/3] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen
2025-02-24 5:59 ` [PATCH v16 1/3] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Ryan Chen
2025-02-24 7:16 ` Rob Herring (Arm)
2025-02-24 9:11 ` Krzysztof Kozlowski
2025-02-24 9:12 ` Krzysztof Kozlowski
2025-02-26 9:28 ` Ryan Chen
2025-02-26 9:56 ` Krzysztof Kozlowski
2025-02-27 8:19 ` Ryan Chen
2025-02-27 20:04 ` Krzysztof Kozlowski
2025-03-05 9:35 ` Ryan Chen
2025-03-17 7:45 ` Krzysztof Kozlowski
2025-03-17 9:21 ` Ryan Chen
2025-03-19 7:44 ` Krzysztof Kozlowski
2025-03-19 11:12 ` Ryan Chen
2025-03-24 7:21 ` Krzysztof Kozlowski
2025-03-24 8:30 ` Ryan Chen
2025-03-24 9:07 ` Krzysztof Kozlowski
2025-03-24 10:01 ` Ryan Chen
2025-03-24 11:10 ` Krzysztof Kozlowski
2025-03-25 9:52 ` Ryan Chen
2025-03-25 10:18 ` Krzysztof Kozlowski
2025-09-10 7:25 ` Jeremy Kerr
2025-09-10 7:44 ` Krzysztof Kozlowski [this message]
2025-09-10 8:31 ` Jeremy Kerr
2025-09-11 1:27 ` Ryan Chen
2025-09-11 1:38 ` Jeremy Kerr
2025-09-11 9:03 ` Jeremy Kerr
2025-09-12 6:37 ` Krzysztof Kozlowski
2025-09-12 7:13 ` Ryan Chen
2025-02-24 5:59 ` [PATCH v16 2/3] i2c: aspeed: support AST2600 i2c new register mode driver Ryan Chen
2025-02-24 8:54 ` Philipp Zabel
2025-02-24 9:04 ` Ryan Chen
2025-02-24 9:32 ` Philipp Zabel
2025-02-28 1:28 ` kernel test robot
2025-02-28 12:38 ` Andy Shevchenko
2025-03-17 7:48 ` Krzysztof Kozlowski
2025-03-17 8:00 ` Andy Shevchenko
2025-03-17 8:51 ` Ryan Chen
2025-03-17 8:57 ` Krzysztof Kozlowski
2025-02-24 5:59 ` [PATCH v16 3/3] i2c: aspeed: support AST2600 i2c new register target " Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9fc4b59-bdcd-4983-b7c2-0fec94e62176@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elbadrym@google.com \
--cc=jk@ozlabs.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=ryan_chen@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox