From: "Moger, Babu" <babu.moger@amd.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
corbet@lwn.net, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de
Cc: fenghua.yu@intel.com, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, paulmck@kernel.org,
akpm@linux-foundation.org, quic_neeraju@quicinc.com,
rdunlap@infradead.org, damien.lemoal@opensource.wdc.com,
songmuchun@bytedance.com, peterz@infradead.org,
jpoimboe@kernel.org, pbonzini@redhat.com,
chang.seok.bae@intel.com, pawan.kumar.gupta@linux.intel.com,
jmattson@google.com, daniel.sneddon@linux.intel.com,
sandipan.das@amd.com, tony.luck@intel.com, james.morse@arm.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
bagasdotme@gmail.com, eranian@google.com,
christophe.leroy@csgroup.eu, jarkko@kernel.org,
adrian.hunter@intel.com, quic_jiles@quicinc.com,
peternewman@google.com
Subject: Re: [PATCH v12 04/10] x86/resctrl: Add comments on RFTYPE flags hierarchy
Date: Wed, 11 Oct 2023 11:57:02 -0500 [thread overview]
Message-ID: <fa03a5ca-fb16-47bb-a2c8-5cc4d96e54a9@amd.com> (raw)
In-Reply-To: <71539687-13cf-405d-bf7c-27480e49e872@intel.com>
Hi Reinette,
On 10/10/23 19:56, Reinette Chatre wrote:
> Hi Babu,
>
> On 10/10/2023 4:33 PM, Babu Moger wrote:
>> resctrl uses RFTYPE flags for creating resctrl directory structure.
>>
>> Definitions and directory structures are not documented. Add
>> comments to improve the readability and help future additions.
>>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> Tested-by: Peter Newman <peternewman@google.com>
>> Reviewed-by: Peter Newman <peternewman@google.com>
>> Tested-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
>> Reviewed-by: Tan Shaopeng <tan.shaopeng@jp.fujitsu.com>
>> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
>> Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
>> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>> ---
>> v12: Moved the comments from arch/x86/kernel/cpu/resctrl/internal.h
>> to Documentation/arch/x86/resctrl.rst. (Boris)
>> ---
>
> It seems like you just copied the text to the documentation without
> taking into account the destination's use of reST syntax.
>
> I tried a "make htmldocs" to see how this looks but encountered:
> docutils.utils.SystemMessage: [snip]/linux/Documentation/arch/x86/resctrl.rst:398: (SEVERE/4) Unexpected section title.
My bad. Just tested the format by opening using the browser. Forgot about
make htmldocs. Will fix it now.
>
> Please remove my Reviewed-by.
Sure. Will remove Reviewed-by on this patch. Please let me know about
other patches when you get a chance.
--
Thanks
Babu Moger
next prev parent reply other threads:[~2023-10-11 16:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 23:33 [PATCH v12 00/10] x86/resctrl: Miscellaneous resctrl features Babu Moger
2023-10-10 23:33 ` [PATCH v12 01/10] x86/resctrl: Add multiple tasks to the resctrl group at once Babu Moger
2023-10-10 23:33 ` [PATCH v12 02/10] x86/resctrl: Simplify rftype flag definitions Babu Moger
2023-10-10 23:33 ` [PATCH v12 03/10] x86/resctrl: Rename rftype flags for consistency Babu Moger
2023-10-10 23:33 ` [PATCH v12 04/10] x86/resctrl: Add comments on RFTYPE flags hierarchy Babu Moger
2023-10-11 0:56 ` Reinette Chatre
2023-10-11 16:57 ` Moger, Babu [this message]
2023-10-12 16:01 ` Reinette Chatre
2023-10-12 18:28 ` Moger, Babu
2023-10-10 23:33 ` [PATCH v12 05/10] x86/resctrl: Unwind the errors inside rdt_enable_ctx() Babu Moger
2023-10-10 23:33 ` [PATCH v12 06/10] x86/resctrl: Move default group file creation to mount Babu Moger
2023-10-10 23:33 ` [PATCH v12 07/10] x86/resctrl: Introduce "-o debug" mount option Babu Moger
2023-10-10 23:33 ` [PATCH v12 08/10] x86/resctrl: Display CLOSID for resource group Babu Moger
2023-10-10 23:33 ` [PATCH v12 09/10] x86/resctrl: Add support for the files for MON groups only Babu Moger
2023-10-12 16:02 ` Reinette Chatre
2023-10-12 18:29 ` Moger, Babu
2023-10-10 23:33 ` [PATCH v12 10/10] x86/resctrl: Display RMID of resource group Babu Moger
2023-10-12 16:02 ` Reinette Chatre
2023-10-12 22:06 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa03a5ca-fb16-47bb-a2c8-5cc4d96e54a9@amd.com \
--to=babu.moger@amd.com \
--cc=adrian.hunter@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bagasdotme@gmail.com \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=eranian@google.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jarkko@kernel.org \
--cc=jmattson@google.com \
--cc=jpoimboe@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=quic_jiles@quicinc.com \
--cc=quic_neeraju@quicinc.com \
--cc=rdunlap@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=sandipan.das@amd.com \
--cc=songmuchun@bytedance.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox