public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Laight <David.Laight@ACULAB.COM>
To: 'Hans Weber' <hwe.kernel@gmail.com>,
	"torvalds@evo.osdl.org" <torvalds@evo.osdl.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] only call the c function set_bios_mode if the value CONFIG_X86_64 is set.
Date: Sat, 19 Feb 2022 20:44:07 +0000	[thread overview]
Message-ID: <fa07b3858c254cd8947434bdd89412e2@AcuMS.aculab.com> (raw)
In-Reply-To: <20220219203950.106655-1-hwe.kernel@gmail.com>

From: Hans Weber
> Sent: 19 February 2022 20:40
> 
> Signed-off-by: Hans Weber <hwe.kernel@gmail.com>
> ---
>  arch/x86/boot/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/boot/main.c b/arch/x86/boot/main.c
> index e3add857c2c9..e4df8ff1e228 100644
> --- a/arch/x86/boot/main.c
> +++ b/arch/x86/boot/main.c
> @@ -102,14 +102,12 @@ static void query_ist(void)
>   */
>  static void set_bios_mode(void)
>  {
> -#ifdef CONFIG_X86_64
>  	struct biosregs ireg;
> 
>  	initregs(&ireg);
>  	ireg.ax = 0xec00;
>  	ireg.bx = 2;
>  	intcall(0x15, &ireg, NULL);
> -#endif
>  }
> 
>  static void init_heap(void)
> @@ -152,7 +150,9 @@ void main(void)
>  	}
> 
>  	/* Tell the BIOS what CPU mode we intend to run in. */
> +#ifdef CONFIG_X86_64
>  	set_bios_mode();
> +#endif

That should make absolutely no difference.
The empty static function will be inlined and thus discarded.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)


  reply	other threads:[~2022-02-19 20:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-19 20:39 [PATCH] only call the c function set_bios_mode if the value CONFIG_X86_64 is set Hans Weber
2022-02-19 20:44 ` David Laight [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-02-19 20:42 Hans Weber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa07b3858c254cd8947434bdd89412e2@AcuMS.aculab.com \
    --to=david.laight@aculab.com \
    --cc=hwe.kernel@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@evo.osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox