[PATCHv2] selftests/input: add tests for the EVIOCSCLOCKID ioctl

[PATCHv2] selftests/input: add tests for the EVIOCSCLOCKID ioctl

[Dana Elfassy]

This patch introduces tests for the EVIOCSCLOCKID ioctl, for full
coverage of the different clkids

Signed-off-by: Dana Elfassy <dangel101@gmail.com>
---
Changes in v2:
- Replaced clkids numerical values with their equivalent definition

This patch depends on '[v3] selftests/input: Introduce basic tests for evdev ioctls' [1] sent to the ML.
[1] https://patchwork.kernel.org/project/linux-input/patch/20230607153214.15933-1-eballetbo@kernel.org/

 tools/testing/selftests/input/evioc-test.c | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/tools/testing/selftests/input/evioc-test.c b/tools/testing/selftests/input/evioc-test.c
index ad7b93fe39cf..83ce1a3c9b84 100644
--- a/tools/testing/selftests/input/evioc-test.c
+++ b/tools/testing/selftests/input/evioc-test.c
@@ -17,6 +17,7 @@
 #include <sys/stat.h>
 #include <time.h>
 #include <unistd.h>
+#include <linux/time.h>
 
 #include "../kselftest_harness.h"
 
@@ -234,4 +235,33 @@ TEST(eviocsrep_set_repeat_settings)
 	selftest_uinput_destroy(uidev);
 }
 
+TEST(eviocsclockid_set_clockid)
+{
+	struct selftest_uinput *uidev;
+	int clkid = CLOCK_REALTIME;
+	int rc;
+
+	rc = selftest_uinput_create_device(&uidev, -1);
+	ASSERT_EQ(0, rc);
+	ASSERT_NE(NULL, uidev);
+
+	rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+	ASSERT_EQ(0, rc);
+
+	clkid = CLOCK_MONOTONIC;
+	rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+	ASSERT_EQ(0, rc);
+
+	clkid = CLOCK_BOOTTIME;
+	rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+	ASSERT_EQ(0, rc);
+
+	// case default
+	clkid = -1;
+	rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
+	ASSERT_EQ(-1, rc);
+
+	selftest_uinput_destroy(uidev);
+}
+
 TEST_HARNESS_MAIN
-- 
2.41.0

Re: [PATCHv2] selftests/input: add tests for the EVIOCSCLOCKID ioctl

[Enric Balletbo Serra]

Hi Dana,

Thank you for the patch.

Missatge de Dana Elfassy <delfassy@redhat.com> del dia dl., 3 de jul.
2023 a les 11:47:
>
> This patch introduces tests for the EVIOCSCLOCKID ioctl, for full
> coverage of the different clkids
>
> Signed-off-by: Dana Elfassy <dangel101@gmail.com>

I ran the tests and look at code coverage of them and they cover what
is expected so

Reviewed-by: Enric Balletbo i Serra <eballetbo@kernel.org>

Cheers,
  Enric


> ---
> Changes in v2:
> - Replaced clkids numerical values with their equivalent definition
>
> This patch depends on '[v3] selftests/input: Introduce basic tests for evdev ioctls' [1] sent to the ML.
> [1] https://patchwork.kernel.org/project/linux-input/patch/20230607153214.15933-1-eballetbo@kernel.org/
>
>  tools/testing/selftests/input/evioc-test.c | 30 ++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
>
> diff --git a/tools/testing/selftests/input/evioc-test.c b/tools/testing/selftests/input/evioc-test.c
> index ad7b93fe39cf..83ce1a3c9b84 100644
> --- a/tools/testing/selftests/input/evioc-test.c
> +++ b/tools/testing/selftests/input/evioc-test.c
> @@ -17,6 +17,7 @@
>  #include <sys/stat.h>
>  #include <time.h>
>  #include <unistd.h>
> +#include <linux/time.h>
>
>  #include "../kselftest_harness.h"
>
> @@ -234,4 +235,33 @@ TEST(eviocsrep_set_repeat_settings)
>         selftest_uinput_destroy(uidev);
>  }
>
> +TEST(eviocsclockid_set_clockid)
> +{
> +       struct selftest_uinput *uidev;
> +       int clkid = CLOCK_REALTIME;
> +       int rc;
> +
> +       rc = selftest_uinput_create_device(&uidev, -1);
> +       ASSERT_EQ(0, rc);
> +       ASSERT_NE(NULL, uidev);
> +
> +       rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
> +       ASSERT_EQ(0, rc);
> +
> +       clkid = CLOCK_MONOTONIC;
> +       rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
> +       ASSERT_EQ(0, rc);
> +
> +       clkid = CLOCK_BOOTTIME;
> +       rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
> +       ASSERT_EQ(0, rc);
> +
> +       // case default
> +       clkid = -1;
> +       rc = ioctl(uidev->evdev_fd, EVIOCSCLOCKID, &clkid);
> +       ASSERT_EQ(-1, rc);
> +
> +       selftest_uinput_destroy(uidev);
> +}
> +
>  TEST_HARNESS_MAIN
> --
> 2.41.0
>

Re: [PATCHv2] selftests/input: add tests for the EVIOCSCLOCKID ioctl

[Shuah Khan]

On 7/3/23 03:47, Dana Elfassy wrote:
> This patch introduces tests for the EVIOCSCLOCKID ioctl, for full
> coverage of the different clkids
> 
> Signed-off-by: Dana Elfassy <dangel101@gmail.com>

Thanks for the patch. Signed-of-by doesn't match the from
email. Please fix that and resend - please add Reviewed-by
tags to the resend

thanks,
-- Shuah