From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh-b4-smtp.messagingengine.com (fhigh-b4-smtp.messagingengine.com [202.12.124.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63DAE1DFE1 for ; Mon, 3 Mar 2025 08:31:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.155 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740990718; cv=none; b=tXGkSRwNDxCKHUjseQmZdTBr+YAI79AdBKrTLTVfN5w4buADhIlCWkVN8HHkZqGP8KQWTGog9OLATzo3ptBirPeSsTII89dPM3VdTkA8CV30wwNhe96GZlsVR2/WpMkC5DY5dEI3aId8rxziYXz8dd+l7glcqt3p+2iqHqAXQPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740990718; c=relaxed/simple; bh=agnRvcLuOv+42lmgdsYIEJwJMW09zxWsAsSCJzsS5mY=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=L3gkbN8oJ9dZsOjAo/tgwfV3APnkat6fuzcI8g8Z4jM2WcBpxlOm+faHUQn4/rzNeGAo8As+2XewOj5AzNXkR3ArZPegEoJMOiAVlZ87aNtpLeGWjh0jMBfKqFd0Xvrl4LxuBM0NPJi6BQs+lbQGtyrdMos0mtrv2mSEJy98MEI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de; spf=pass smtp.mailfrom=arndb.de; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b=URTs/h7N; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=c/dQdYU+; arc=none smtp.client-ip=202.12.124.155 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arndb.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arndb.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="URTs/h7N"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="c/dQdYU+" Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfhigh.stl.internal (Postfix) with ESMTP id 1B733254012B; Mon, 3 Mar 2025 03:31:55 -0500 (EST) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-09.internal (MEProxy); Mon, 03 Mar 2025 03:31:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1740990714; x=1741077114; bh=VDBDcAjc8C1hCmrc3ZAbJzRn82LoqB/QHim1ljqqCMI=; b= URTs/h7NehXAEG7+UnxWIBsO+nYRMPnUXDiiSScDKP+5qfbKL3qCgipdiNwtDeGN nc/ESKtZEzYXy0HfXJq/fuJNJhDjGXpaiX2EG71JxCyzT8cDUlAxurBbHIcs7Rck hC0oXrhpoaso45FQrxSBXtsxPedYK57pUsDN+q1Yijz0l2N3O/ToijcUwkXHxU+U LKYcDp6q4VRsEhVQXalkF2g5OiNVDrgams2ga880BMD7X+riERBfE2ghVVEB02xC u4VfLgQpLmQ6xrveBS75pKgc+ZGiZQ6Fbptm5UCcKzkUxU2Fs/Xs0zVDeb6QmOlP 5yaZIKaOIuypCG/ZGSktUQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1740990714; x= 1741077114; bh=VDBDcAjc8C1hCmrc3ZAbJzRn82LoqB/QHim1ljqqCMI=; b=c /dQdYU+/yS8kMIL97aRpHMt8WvncXzQ02tcdgC3CQ4lUDn8OfCO6utbVp1cX8/Qy cBj6BJIYmMVL/AVZigGjVs5FCMa2zDYwgZ4BQOf6yMXxTdtnADCWGAqyK0uosGif WpC0ZfosKxIt0FbzpJP2E/WtxKpx4bY8nP9wc1ipGrsfmy1d6S036/+nqgtkZNpz a8FwlxOTXKX5NREhHad/l4NavjsRsS5ISmwsDpWCHHn6POAAQP9Bmw3VtYgUsVEp jhEhtsVUmhCFx8NSNDrQzZjcdP7pV0V35LcoWbGw5PlkSMdjlzqmx5DuGnPf8UfW f7KQEHRQ8TbDTjyug10Qg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdelkeeihecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredt tdenucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusg druggvqeenucggtffrrghtthgvrhhnpefhtdfhvddtfeehudekteeggffghfejgeegteef gffgvedugeduveelvdekhfdvieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggvpdhnsggprhgtphhtthhopeej pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopehsihhmohhnrgesfhhffihllhdrtg hhpdhrtghpthhtoheprghirhhlihgvugesghhmrghilhdrtghomhdprhgtphhtthhopehr rggrghdrjhgruggrvhesihhnthgvlhdrtghomhdprhgtphhtthhopegrnhgurhhihidrsh hhvghvtghhvghnkhhosehlihhnuhigrdhinhhtvghlrdgtohhmpdhrtghpthhtohepghhr vghgkhhhsehlihhnuhigfhhouhhnuggrthhiohhnrdhorhhgpdhrtghpthhtohepughrih dquggvvhgvlheslhhishhtshdrfhhrvggvuggvshhkthhophdrohhrghdprhgtphhtthho pehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id A2E482220072; Mon, 3 Mar 2025 03:31:54 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Mon, 03 Mar 2025 09:31:06 +0100 From: "Arnd Bergmann" To: "Andy Shevchenko" , "Raag Jadav" Cc: "Greg Kroah-Hartman" , "Dave Airlie" , "Simona Vetter" , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: References: <20250227070747.3105451-1-raag.jadav@intel.com> <0011035a-5816-48c4-9fe4-c0b9db3c8e72@app.fastmail.com> Subject: Re: [PATCH v3 0/2] Cleanup io.h Content-Type: text/plain Content-Transfer-Encoding: 7bit On Mon, Mar 3, 2025, at 08:48, Andy Shevchenko wrote: > On Fri, Feb 28, 2025 at 09:08:15PM +0200, Raag Jadav wrote: >> > > > Ah, you mean devres related? >> > > >> > > Yeah, couldn't find it on Arnd's tree and I'm not sure if this series >> > > works without it. >> > >> > But err.h is included in the io.h, no? Or did I misunderstand the point? >> >> First patch on the immutable tag moves IOMEM_ERR_PTR() to err.h and here >> we're dropping err.h from io.h. So without the tag this series will probably >> break IOMEM_ERR_PTR(). > > I see, I think it might be due to some other includes that make this happen. > Whatever, I assume that Arnd heavily tested this anyway, so it's good to go > independently on the immutable tag.. I see that err.h gets included through at least linux/string.h, linux/logic_pio.h and (depending on the architecture architectures) asm/page.h, so there is no huge risk of something breaking here ;-) Ideally all of the above should be removed here, but to do it right, the linux/pgtable.h dependency needs to also be replaced with a smaller pgprot_t specific one, which takes a bit of cross-platform work as the definition is not in a consistent place at the moment. The change below still builds fine, and that likely indicates that the same headers are still included from either asm/io.h or asm/pgtable.h on the architectures I'm testing. Arnd ---- diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h index 402020b23423..60a162591072 100644 --- a/include/asm-generic/io.h +++ b/include/asm-generic/io.h @@ -7,16 +7,16 @@ #ifndef __ASM_GENERIC_IO_H #define __ASM_GENERIC_IO_H -#include /* I/O is all done through memory accesses */ -#include /* for memset() and memcpy() */ #include #include #include +#include #ifdef CONFIG_GENERIC_IOMAP #include #endif +#include #include #include diff --git a/include/linux/logic_pio.h b/include/linux/logic_pio.h index 8f1a9408302f..a83286bf13ab 100644 --- a/include/linux/logic_pio.h +++ b/include/linux/logic_pio.h @@ -8,7 +8,9 @@ #ifndef __LINUX_LOGIC_PIO_H #define __LINUX_LOGIC_PIO_H -#include +#include + +struct fwnode_handle; enum { LOGIC_PIO_INDIRECT, /* Indirect IO flag */