From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0657D36656B for ; Wed, 19 Nov 2025 15:36:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763566586; cv=none; b=meXfFQ+4ec59PnXlMc05GIEQ7ACIEk09uApp3uuwB4g6vATMyFajdA1QTeeicAYkuOFLN5QCgEnGCKs8X24tzoQyyfuXeKx5DJS85YDGjfEM9v2WcYslKjvK0PYsPnZfuTOqaq9Q/BPPN4qXqblPAHfVNUuiQh48obI8IRWvUuM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763566586; c=relaxed/simple; bh=wTa40yMHXbA/hD3kwwRs4I02AX8q+hmhww5CzFpBfIs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Dk7R4QHARXLZzwgoVXdjs0SHx6u4rXCIlU7HQf8B2mkZ7qVIs/mFDOm5CUVLS/sM2m+dnnmGBCSVYegI2hzdTRtDpbpRVjvpvCpi8PVE9M8Il8BBGHMKuUy+hL3eOIkMHyEtIfAqrQraN2d1HcsrvdJQCrzgxXV54nFEiB7OopM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HSaFDFQB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fnKiPT5Z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HSaFDFQB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fnKiPT5Z" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AJAqxSs536924 for ; Wed, 19 Nov 2025 15:36:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wP9c2XnhztLAURhj3zwRP4AijueQ56rnmPiNweW8zA4=; b=HSaFDFQBv/9hndr9 pGeruXzQJ8zJ5BiQW52RIcJbMgHow7HYJ4ozG/+v8xiFUh48JQZr4gMBouArt/GV COGx1EnbBiMTkmasCrosvfbS3bpeBjz3wdykH1Pv/PYbsVe+9D06zHe0DnYZN6md E6XEAfu3sHffwi7VJCc+NEH961MeiX0hU/VYND0+3WnbIGM6T8DfqAtqw7lqKPyo /8mFIoODqxbxzxiyfVesndv18BODZ2LE7MJqV1soSSupGti6VRiEEFdOpUeegpBW z0EfATo4TiFd18lmJMKEUHypfF0ukxmGhy1slbkFK9Ke+HPOeYtFd+ARpc+VUXFd gqu8vA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ah65t214w-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Nov 2025 15:36:24 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4ed69f9ce96so324657641cf.3 for ; Wed, 19 Nov 2025 07:36:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763566583; x=1764171383; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wP9c2XnhztLAURhj3zwRP4AijueQ56rnmPiNweW8zA4=; b=fnKiPT5Z03QZZP1aHnvjuM1JJWQb43X3ptYo923nx/x6bys+Zdja1jQoZVy6r/IZBy JptbW3vKwJMUCEzlPiP1SpoQxGrcSY5N1NUJYoe8Ltg3GsMu4vVigHg3xmPW32TddUNM cv52TgMxL6QD/iC79XfIuSRJmEfj32UWdXeNFrOdfrzgbMIzA7+aA1A1JA9HXLUDM0q9 ztPLL1ni0ns+vSFR5204TevemRf1pkYGWMIRSbqnyyM1ZBqW0J0P6qgbs4EMSnj+3GvX Tgc1UOlBACK1oRCAuX5uM0OTysIFvv3b484AeWbIWv1WRsNs5y43D15UrNnIHpw0sJvB kvVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763566583; x=1764171383; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wP9c2XnhztLAURhj3zwRP4AijueQ56rnmPiNweW8zA4=; b=LFSEnpgYeCzEeXb6IoaRFEsKYAmtBz1wcTidEs3dFqMDfxG/0uI40sBQCQCMrd5oD9 OqoiiPa5Tw8V3YQrJIQUUBbSxgcPuh2FaXl+Maa06oH/Rz2QjzkxM73l6C7KjXj+rmCW eJKuGpu/GwHETNxyxvygR89+/1pRiVODPXyXvykqYxSZyCQyW5ECf2sI+Uj3pDaAJ+rN m0Mc3bi16NtDCxztpGP/1jCM03kSY21Ik5ctxvfRzzw+30qOs8RcBKJdpRTLxyu7iYGj xbozldVM+eXPMwvtFysBDcQbOlCqD68N+s7fjVAIPATZ9GSqLIEQQPHVAtpvaFWo96YP CIpg== X-Forwarded-Encrypted: i=1; AJvYcCW5vZLELBqfPBYoYcIWA3smBltUKo4CmsRHOz1Cr5Z2jjnXS+17ZiX/ZG8SYr0yJ7oXDE625iSax7rHGEo=@vger.kernel.org X-Gm-Message-State: AOJu0YxP0O9hscCk6KHfbLSKCbxgwrCTsxPJaP0u35VHgewPfibZwZhg ue3b4uhX2NyQ6n0/FLtu9rF2eicZObGnNfzUKR/El/qpVcIbUh5NhdL6fr2iGfdB/JFY4SiHy49 yUpstiYc/fseRY3EtZ68HDi6L70NC7Y9b/PCEYqGHs51nFL2tn91WNbzTdpuO/I0jpqs= X-Gm-Gg: ASbGncvJ36VjLcZs6JyWcp9Lb1JFL9VTKzCpk3USRulSQfa2rL4kE8qW2KQk79Tx0Kw 3PLj7OtecCXCKcYD4ysSQsCOmXnPBenZhbghcv6rW3yggohVI57NOOPphhwe2U1gQOxKLclXuGz Mz8ZsqTmOZYYi7yvhh4XkXMN6JSQTjb1bT19sMgfz29V3TkXNTuSqSZpupIhyW+cNqwBNLC5uk5 y/zyK2qVopJeG//DkDHhZiEV9LPWBgoRp4WAVgxnp1+Z3WrFFwKUWD+ehv+KOy+fXBOt0oecJuS yKydeWqY6Soa37cWyKyiPoX56qJevbNz43J64K9XJIZXmZEqpXybz+p+j0nwi7Cyzf0RLw25KIb TGy5AhLxPlDqmY4q9t8fn9rloCn4qWYuXZsyc X-Received: by 2002:a05:622a:52:b0:4ec:ee7c:3165 with SMTP id d75a77b69052e-4edf214a917mr264089221cf.81.1763566583174; Wed, 19 Nov 2025 07:36:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IG5uxE4x9fVe+zMA0r2RYYf4J9RcY1a3oV+0kiDa5+6vY8Fzo2+GVxSxUf3+QhzNzjfWm/LuA== X-Received: by 2002:a05:622a:52:b0:4ec:ee7c:3165 with SMTP id d75a77b69052e-4edf214a917mr264088701cf.81.1763566582708; Wed, 19 Nov 2025 07:36:22 -0800 (PST) Received: from [192.168.68.121] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-42b53f1fd50sm39044188f8f.38.2025.11.19.07.36.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Nov 2025 07:36:22 -0800 (PST) Message-ID: Date: Wed, 19 Nov 2025 15:36:21 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/9] ASoC: codecs: lpass-wsa-macro: remove useless gain read/write sequence To: Jonathan Marek , linux-arm-msm@vger.kernel.org Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , "open list:QCOM AUDIO (ASoC) DRIVERS" , open list References: <20251117051523.16462-1-jonathan@marek.ca> <20251117051523.16462-2-jonathan@marek.ca> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20251117051523.16462-2-jonathan@marek.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=avK/yCZV c=1 sm=1 tr=0 ts=691de3f8 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RAbU-raeAAAA:8 a=EUspDBNiAAAA:8 a=RmIaNmV--FFQmAx1t8oA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 a=JiizpSU_mAIq9zsZDqn2:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE5MDEyNCBTYWx0ZWRfX/5/AZGASlYgM wLxb5KyK3ISjW8frz2kXTbzuk3xfqlYSrVMs60BDpESWIcQv7u0G9qG/6lcamxlVSNu5MgRZRrN 9+TEny66t0z4vouQER5Qy3kzz9QWXzv/Zz9Jqklku/dREGg7dpWbAnD9d54MQUZH5sa5fw9Hrbe K5zsmqGrMShxOgOloKs1SGY0mVqKgifn2y7nxZrbVcAXqT1FeBQDqW30M2RaEHbZRpJKJNDV2kp rOoekmusiix+eLrv1MuAGGce13b21BuxLSXeLtERFe/IuzkFjZDORuf8vWaI79tDrMNTFGQyLmh L+hZnoAKxW9B2Yyv8p+GjPZeErqDAjL0ix7mfkjnJyTZ0l4vy3WpFS4QZnMqFygJl9iDgPS2o9Y NuAXJmBFTECnyAPGxJf467cGZohhUg== X-Proofpoint-GUID: MYcpAWgKO-03-OXLQfytwXfWZzdTjC2D X-Proofpoint-ORIG-GUID: MYcpAWgKO-03-OXLQfytwXfWZzdTjC2D X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-19_04,2025-11-18_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 adultscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511190124 On 11/17/25 5:15 AM, Jonathan Marek wrote: > Reading and writing the same value to this register does nothing. > > Looking at downstream driver it seems there was meant to be an offset added > > Signed-off-by: Jonathan Marek Tested-by: Srinivas Kandagatla #on T14s Reviewed-by: Srinivas Kandagatla > --- > sound/soc/codecs/lpass-wsa-macro.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) > > diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c > index 6e54c1beac8f9..6f16d54aee401 100644 > --- a/sound/soc/codecs/lpass-wsa-macro.c > +++ b/sound/soc/codecs/lpass-wsa-macro.c > @@ -1567,17 +1567,14 @@ static int wsa_macro_enable_mix_path(struct snd_soc_dapm_widget *w, > struct snd_kcontrol *kcontrol, int event) > { > struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); > - u16 path_reg, gain_reg; > - int val; > + u16 path_reg; > > switch (w->shift) { > case WSA_MACRO_RX_MIX0: > path_reg = CDC_WSA_RX0_RX_PATH_MIX_CTL; > - gain_reg = CDC_WSA_RX0_RX_VOL_MIX_CTL; > break; > case WSA_MACRO_RX_MIX1: > path_reg = CDC_WSA_RX1_RX_PATH_MIX_CTL; > - gain_reg = CDC_WSA_RX1_RX_VOL_MIX_CTL; > break; > default: > return 0; > @@ -1585,8 +1582,6 @@ static int wsa_macro_enable_mix_path(struct snd_soc_dapm_widget *w, > > switch (event) { > case SND_SOC_DAPM_POST_PMU: > - val = snd_soc_component_read(component, gain_reg); > - snd_soc_component_write(component, gain_reg, val); > break; > case SND_SOC_DAPM_POST_PMD: > snd_soc_component_update_bits(component, path_reg, > @@ -1931,7 +1926,6 @@ static int wsa_macro_enable_interpolator(struct snd_soc_dapm_widget *w, > struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); > u16 gain_reg; > u16 reg; > - int val; > struct wsa_macro *wsa = snd_soc_component_get_drvdata(component); > > if (w->shift == WSA_MACRO_COMP1) { > @@ -1971,8 +1965,6 @@ static int wsa_macro_enable_interpolator(struct snd_soc_dapm_widget *w, > CDC_WSA_RX_PGA_HALF_DB_MASK, > CDC_WSA_RX_PGA_HALF_DB_ENABLE); > } > - val = snd_soc_component_read(component, gain_reg); > - snd_soc_component_write(component, gain_reg, val); > wsa_macro_config_ear_spkr_gain(component, wsa, > event, gain_reg); > break;