public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	rusty@rustcorp.com.au
Subject: Re: [PATCH] virtio: add missing include to virtio_net.h
Date: Wed, 29 Apr 2009 19:20:38 -0600	[thread overview]
Message-ID: <fa686aa40904291820q9019708oaa737c6d8f65ca02@mail.gmail.com> (raw)
In-Reply-To: <20090429.174943.133929746.davem@davemloft.net>

On Wed, Apr 29, 2009 at 6:49 PM, David Miller <davem@davemloft.net> wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
> Date: Tue, 28 Apr 2009 09:46:54 -0600
>
> [ Grant, please CC: netdev on networking patches, thanks. ]

Oops, sorry about that; I had in my head "virtio" and it didn't even
occur to me that it was also netdev.  :-)

g.

>
>> virtio_net.h uses the macro ETH_ALEN which is defined in linux/if_ether.h.
>> Discovered when hacking on virtio-over-pci patches.
>>
>> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
>
> Rusty, ACK?
>
> I haven't been able to get responses from Rusty on virtio net
> patches, so if he doesn't start responding soon I'm going to
> integrates the fixes I've seen lately as they all look
> reasonable to me.
>
>> ---
>>
>>  include/linux/virtio_net.h |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>>
>> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h
>> index 242348b..cec79ad 100644
>> --- a/include/linux/virtio_net.h
>> +++ b/include/linux/virtio_net.h
>> @@ -4,6 +4,7 @@
>>   * compatible drivers/servers. */
>>  #include <linux/types.h>
>>  #include <linux/virtio_config.h>
>> +#include <linux/if_ether.h>
>>
>>  /* The ID for virtio_net */
>>  #define VIRTIO_ID_NET        1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

  reply	other threads:[~2009-04-30  1:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-28 15:46 [PATCH] virtio: add missing include to virtio_net.h Grant Likely
2009-04-30  0:49 ` David Miller
2009-04-30  1:20   ` Grant Likely [this message]
2009-05-01 22:34 ` David Miller
2009-05-05  4:24 ` Rusty Russell
2009-05-05  4:27   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa686aa40904291820q9019708oaa737c6d8f65ca02@mail.gmail.com \
    --to=grant.likely@secretlab.ca \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox