From: Grant Likely <grant.likely@secretlab.ca>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uartlite: Fix build on sparc.
Date: Wed, 3 Mar 2010 08:51:27 -0700 [thread overview]
Message-ID: <fa686aa41003030751x6fbf4cc2t119f225e31bd45c8@mail.gmail.com> (raw)
In-Reply-To: <20100303.025026.243831910.davem@davemloft.net>
On Wed, Mar 3, 2010 at 3:50 AM, David Miller <davem@davemloft.net> wrote:
>
> We can get this driver enabled via MFD_TIMBERDALE which only
> requires GPIO to be on.
>
> But the of_address_to_resource() function is only present on
> powerpc and microblaze, so we have to conditionalize the
> CONFIG_OF probing bits on that.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> diff --git a/drivers/serial/uartlite.c b/drivers/serial/uartlite.c
> index ab2ab3c..f0a6c61 100644
> --- a/drivers/serial/uartlite.c
> +++ b/drivers/serial/uartlite.c
> @@ -19,7 +19,7 @@
> #include <linux/interrupt.h>
> #include <linux/init.h>
> #include <asm/io.h>
> -#if defined(CONFIG_OF)
> +#if defined(CONFIG_OF) && (defined(CONFIG_PPC32) || defined(CONFIG_MICROBLAZE))
ARM will probably end up using this driver. How about simply
defined(CONFIG_OF) && !defined(CONFIG_SPARC)?
Or if you prefer, I could expedite my patch that moves
of_address_to_resource() into common code (it's currently in my test
branch). I wasn't planning to merge it until 2.6.35, but it is pretty
low risk so I'd be comfortable merging it now.
g.
next prev parent reply other threads:[~2010-03-03 15:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 10:50 [PATCH] uartlite: Fix build on sparc David Miller
2010-03-03 15:51 ` Grant Likely [this message]
2010-03-03 16:04 ` David Miller
2010-03-03 16:40 ` Grant Likely
2010-03-03 16:44 ` Grant Likely
2010-03-03 16:48 ` David Miller
2010-03-03 18:52 ` Grant Likely
2010-03-03 18:55 ` Grant Likely
2010-03-04 2:50 ` Greg KH
2010-03-04 4:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa686aa41003030751x6fbf4cc2t119f225e31bd45c8@mail.gmail.com \
--to=grant.likely@secretlab.ca \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox