From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31B28C433EF for ; Wed, 8 Jun 2022 01:29:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345757AbiFHBYH (ORCPT ); Tue, 7 Jun 2022 21:24:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1453119AbiFGXO5 (ORCPT ); Tue, 7 Jun 2022 19:14:57 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C16893B4EE5 for ; Tue, 7 Jun 2022 14:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654635899; x=1686171899; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=FPcIftRj6V6O6B26UF70MyNErLXGhjWNb6LX0nAvIH0=; b=OXyOO2/+sbp8npJP4nWVU3b9GSfH7blo8zVXIQQgEglsQyKY9RrRgcdq 2ISm/yAOG1ICHPVLJiyLXx7YS5eBwS/5zQqry9gMgVVzCnXNK05WOhZ+3 jBKhLKuMQbjOHH9i5zsQuaDnoEP4laJzTWiHsn8Xw1am1kutWGLwybOtW LrztkVxqFU5loWHUgYq8pqHh++01C4TC1bBzoow8rdWZM9Dq44dUKTv3n qNmEeNQ02HMhr5BpJlLClW6LtRKBYOBV1HSoF7YAP5OO7/IL2genxHyYl hMeH/iau0UHgysQ5v2qNg9YKsBO8vJQZqN3A3aU+z8Opai5QOM6QSbqSm g==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="277746378" X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="277746378" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 13:16:00 -0700 X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="584375949" Received: from schen9-mobl.amr.corp.intel.com ([10.251.8.166]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 13:15:59 -0700 Message-ID: Subject: Re: [PATCH v5 2/9] mm/demotion: Expose per node memory tier to sysfs From: Tim Chen To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org Cc: Wei Xu , Huang Ying , Greg Thelen , Yang Shi , Davidlohr Bueso , Tim C Chen , Brice Goglin , Michal Hocko , Linux Kernel Mailing List , Hesham Almatary , Dave Hansen , Jonathan Cameron , Alistair Popple , Dan Williams , Feng Tang , Jagdish Gediya , Baolin Wang , David Rientjes Date: Tue, 07 Jun 2022 13:15:59 -0700 In-Reply-To: <20220603134237.131362-3-aneesh.kumar@linux.ibm.com> References: <20220603134237.131362-1-aneesh.kumar@linux.ibm.com> <20220603134237.131362-3-aneesh.kumar@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2022-06-03 at 19:12 +0530, Aneesh Kumar K.V wrote: > > > +static struct memory_tier *__node_get_memory_tier(int node) > +{ > + struct memory_tier *memtier; > + > + list_for_each_entry(memtier, &memory_tiers, list) { We could need to map node to mem_tier quite often, if we need to account memory usage at tier level. It will be more efficient to have a pointer from node (pgdat) to memtier rather than doing a search through the list. > + if (node_isset(node, memtier->nodelist)) > + return memtier; > + } > + return NULL; > +} > + > Tim