From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754868AbcIJO2a (ORCPT ); Sat, 10 Sep 2016 10:28:30 -0400 Received: from mout.web.de ([212.227.17.12]:56618 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753229AbcIJO23 (ORCPT ); Sat, 10 Sep 2016 10:28:29 -0400 Subject: [PATCH 4/7] cfag12864b: Return directly after a failed get_zeroed_page() To: kernel-janitors@vger.kernel.org, Miguel Ojeda Sandonis References: <566ABCD9.1060404@users.sourceforge.net> <3d24b514-4e99-86ea-d69e-49a0b1edd286@users.sourceforge.net> Cc: LKML , Julia Lawall From: SF Markus Elfring Message-ID: Date: Sat, 10 Sep 2016 16:28:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <3d24b514-4e99-86ea-d69e-49a0b1edd286@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:+wzCrGQU87RiAEHREMoq7eyiA12GB//hdA0ZDah53n8nHktduEM lrcl63SwtrScUcUpyA3ryhMsZsn2edsqXyrBLIOw7dJ9TvUIcsKNAI9o+Aj3t2U7v4dog8c o5w5RF1DSkhcFrPk7X1rdutCAXXZLk7TPbfdjpkwR4tsNk0zkExWitu+6yw68EGt1Uhavk7 19Ymht/OOZme9TUNySdrg== X-UI-Out-Filterresults: notjunk:1;V01:K0:TpHQHi4h+bE=:tAIr11sbkDK7Zof9+uz84K jYmTH5Mn058L6OA4X6hskfvA+VnmhWaUp5mCaSvxeZK8hKMO7sOAD4VQxcnRmYzKLTraHUKgL xC7qdR+SOX4/J2QJxDu6fimT1i3PHi+xby43aW59UT0JsFMi7jdbSqLESy2t0WomMUZceUV3A uoCn6Xvphg9qKgmX15eZlM5fFlAqi7wCsM+PFvbZdZgKZMd8vAsrjlkC0LDzysLS0plZHOXCJ BHIJTivDe9GBZ5xEa/zjr4afFLCTsXZ0Eu+JXkFCIf2fln25Un35xfzLe9MfOU+4a+S8C/6S0 s8a40SQ2Kt3c7ta18ktQnXy+wkDxr53rNvQjQCyWq03vgi2Nz6uUoc1OfeTDItmwG78dIbmXn 9figgtA8ZznyXHsAiBAiT8VaAo63cUriVR0uTFLNkLvg2l1HsnMiebXYHE6Ay9Rh6lK2r1160 PbqP+/nQFR6tG645haRhV4KTfpT1oFwo9103DA1kMcPp03npP/tOjb9GsPwKSVOmS3pxp3yGa cT8GK2jnDHBr27sVcvzBAFGs3qmorQjx0KAV02VVQaNnOtnSCzQMb6Fa7I9gUETxxPVaLIqhm HpeZSrq4MF3Zh2r3lHeKSxCCcMluzYehjg3oKRGX+KSyZYpD1GGYYncOMDj6dOYSddsqiPbZK Y5fcYRRs7vse7WKFogkLfoW7EuPJ7hcqkMPrqHpapEXdK6bjwobgWwo+f+3FVekHvktetp/vO GI4VWrJlvxHBM6gl9Lf8gtADyyXJgDVhVhEZSuWJSNYC9PKh5cT5IKvlwTuc/+lv9L+s+jeKk 7JOU0eU Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 10 Sep 2016 15:30:56 +0200 * Return directly after a call of the function "get_zeroed_page" failed at the beginning. * Delete the jump label "none" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- drivers/auxdisplay/cfag12864b.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/auxdisplay/cfag12864b.c b/drivers/auxdisplay/cfag12864b.c index 921e177..2fa149b 100644 --- a/drivers/auxdisplay/cfag12864b.c +++ b/drivers/auxdisplay/cfag12864b.c @@ -343,8 +343,7 @@ static int __init cfag12864b_init(void) if (cfag12864b_buffer == NULL) { printk(KERN_ERR CFAG12864B_NAME ": ERROR: " "can't get a free page\n"); - ret = -ENOMEM; - goto none; + return -ENOMEM; } cfag12864b_cache = kmalloc_array(CFAG12864B_SIZE, @@ -370,8 +369,6 @@ cachealloced: bufferalloced: free_page((unsigned long) cfag12864b_buffer); - -none: return ret; } -- 2.10.0