From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC3CC3A452C for ; Fri, 10 Apr 2026 07:36:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775806592; cv=none; b=HDFri4ArFTGPJ7I7bNEtJf3kFwgw9QybubcSdFs0+vksPEcsDK4EAzcbjraNEKFWue7RyIswyDt8U3mGECmVjL4YZrmARv215teMMXgySwt73jcNcd9df+YigT4Rkl6+SWz2oi+EO6UeNAoTwYq2HJd5ik34mi5rDIu1UTwXld4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775806592; c=relaxed/simple; bh=TE2UH3iUtZT3usxfJKhS2MoVfQ2C13jefaDKHTlBX5Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W3AKTTULAcbqIQ9kvTsA1Cxa/UbvWQDiRqnrQ0yf5PifbeLQ/KMub0NNyF4mgUWNeo3D9XupDLBsik8AtcJnqlt5doaKzkZR31HlwFvlwItlVIPzmXi1vbTWfdnzFFPOe9omOK8OWkUS9jU/0FuEHVHzk1k/URQIQWtiRHt1OT4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=O61gXLMN; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="O61gXLMN" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1775806588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VTLYMwh8+2dL09yw+nIB+tqwR8xI7oLsaoxXJ0V1RBE=; b=O61gXLMNMSEv+T1eGeGemtxKZe+hAaGnN7ZZ8JADfRq/tuWvEfDMrbOOifOEc2bCQKRYDn oxKPgbruDqCZSGRZq5smu2fSXIssEadBcmDHnwu1bfUDtAk0H103o1F/APMoMO/m0M5mlY XDEnP3XB3ZL8PuxqK1oFd/XRb5QRM9w= Date: Fri, 10 Apr 2026 15:36:21 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2] mm/khugepaged: use ALIGN helpers for PMD alignment To: SeongJae Park Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Ye Liu , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260410001834.77924-1-sj@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ye Liu In-Reply-To: <20260410001834.77924-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT 在 2026/4/10 08:18, SeongJae Park 写道: > On Thu, 9 Apr 2026 09:43:22 +0800 Ye Liu wrote: > >> From: Ye Liu >> >> PMD alignment in khugepaged is currently implemented using a mix of >> rounding helpers and open-coded bitmask operations. >> >> Use ALIGN() and ALIGN_DOWN() consistently for PMD-sized address range >> alignment, matching the preferred style for address and size handling. >> >> No functional change intended. >> >> Signed-off-by: Ye Liu > > Reviewed-by: SeongJae Park > >> >> Changes in v2: >> - Switch to ALIGN()/ALIGN_DOWN() per David's suggestion. >> - Also convert collapse_scan_mm_slot() to keep PMD alignment helpers >> consistent within khugepaged. >> - Update the changelog accordingly. >> - Link to v1:https://lore.kernel.org/all/20260408093534.2373007-1-ye.liu@linux.dev/ > > Nit. Changelog should go to the commentary area [1]. > > [1] https://docs.kernel.org/process/submitting-patches.html#commentary > > Hi SJ, Thanks for the review, the Reviewed-by, and the helpful note. Got it. I'll keep the changelog in the commentary area for future revisions. > Thanks, > SJ > > [...] -- Thanks, Ye Liu