From: Jonathan Cameron <jic23@kernel.org>
To: Derek Robson <robsonde@gmail.com>,
lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
pmeerw@pmeerw.net, gregkh@linuxfoundation.org
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: iio: impedance-analyzer: ad5933.c - style fix
Date: Sun, 19 Feb 2017 11:07:08 +0000 [thread overview]
Message-ID: <fac4dc81-3d56-9592-f20b-9fcce1f5dffb@kernel.org> (raw)
In-Reply-To: <20170212072240.30147-1-robsonde@gmail.com>
On 12/02/17 07:22, Derek Robson wrote:
> Change permissions to octal style.
> Found using checkpatch
>
> Signed-off-by: Derek Robson <robsonde@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders
to play with it.
Jonathan
> ---
> drivers/staging/iio/impedance-analyzer/ad5933.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index 5e96352fa4ac..297665d3fe11 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -345,12 +345,12 @@ static ssize_t ad5933_store_frequency(struct device *dev,
> return ret ? ret : len;
> }
>
> -static IIO_DEVICE_ATTR(out_voltage0_freq_start, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(out_voltage0_freq_start, 0644,
> ad5933_show_frequency,
> ad5933_store_frequency,
> AD5933_REG_FREQ_START);
>
> -static IIO_DEVICE_ATTR(out_voltage0_freq_increment, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(out_voltage0_freq_increment, 0644,
> ad5933_show_frequency,
> ad5933_store_frequency,
> AD5933_REG_FREQ_INC);
> @@ -469,32 +469,32 @@ static ssize_t ad5933_store(struct device *dev,
> return ret ? ret : len;
> }
>
> -static IIO_DEVICE_ATTR(out_voltage0_scale, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(out_voltage0_scale, 0644,
> ad5933_show,
> ad5933_store,
> AD5933_OUT_RANGE);
>
> -static IIO_DEVICE_ATTR(out_voltage0_scale_available, S_IRUGO,
> +static IIO_DEVICE_ATTR(out_voltage0_scale_available, 0444,
> ad5933_show,
> NULL,
> AD5933_OUT_RANGE_AVAIL);
>
> -static IIO_DEVICE_ATTR(in_voltage0_scale, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(in_voltage0_scale, 0644,
> ad5933_show,
> ad5933_store,
> AD5933_IN_PGA_GAIN);
>
> -static IIO_DEVICE_ATTR(in_voltage0_scale_available, S_IRUGO,
> +static IIO_DEVICE_ATTR(in_voltage0_scale_available, 0444,
> ad5933_show,
> NULL,
> AD5933_IN_PGA_GAIN_AVAIL);
>
> -static IIO_DEVICE_ATTR(out_voltage0_freq_points, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(out_voltage0_freq_points, 0644,
> ad5933_show,
> ad5933_store,
> AD5933_FREQ_POINTS);
>
> -static IIO_DEVICE_ATTR(out_voltage0_settling_cycles, S_IRUGO | S_IWUSR,
> +static IIO_DEVICE_ATTR(out_voltage0_settling_cycles, 0644,
> ad5933_show,
> ad5933_store,
> AD5933_OUT_SETTLING_CYCLES);
>
prev parent reply other threads:[~2017-02-19 11:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-12 7:22 [PATCH] Staging: iio: impedance-analyzer: ad5933.c - style fix Derek Robson
2017-02-19 11:07 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fac4dc81-3d56-9592-f20b-9fcce1f5dffb@kernel.org \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=robsonde@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox