From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
Cc: <linux-sound@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Srinivas Kandagatla <srini@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 2/2] ASoC: codecs: lpass-va-macro: check clk_set_rate() return value
Date: Wed, 15 Jul 2026 11:35:42 +0200 [thread overview]
Message-ID: <faeab006-8a65-4352-a33b-e64e30fd2cf2@intel.com> (raw)
In-Reply-To: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v1-2-f0c713ff0b4e@oss.qualcomm.com>
On 7/15/2026 10:29 AM, Ajay Kumar Nandam wrote:
> clk_set_rate() returns 0 on success or a negative errno on failure but
> the VA macro probe function was ignoring it. Check the return value and
> bail out of probe on failure.
Ditto as with 1/2: _is_ ignoring it. s/was/is/.
A patch is a proposal, there is no "was" until it is merged.
Code itself looks good.
next prev parent reply other threads:[~2026-07-15 9:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 8:29 [PATCH 0/2] ASoC: codecs: lpass-{wsa,va}-macro: check clk_set_rate() return value Ajay Kumar Nandam
2026-07-15 8:29 ` [PATCH 1/2] ASoC: codecs: lpass-wsa-macro: " Ajay Kumar Nandam
2026-07-15 9:33 ` Cezary Rojewski
2026-07-15 12:21 ` Ajay Kumar Nandam
2026-07-15 10:06 ` Konrad Dybcio
2026-07-15 8:29 ` [PATCH 2/2] ASoC: codecs: lpass-va-macro: " Ajay Kumar Nandam
2026-07-15 9:35 ` Cezary Rojewski [this message]
2026-07-15 10:06 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=faeab006-8a65-4352-a33b-e64e30fd2cf2@intel.com \
--to=cezary.rojewski@intel.com \
--cc=ajay.nandam@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox