From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B86EC43334 for ; Fri, 22 Jul 2022 18:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236278AbiGVSvN (ORCPT ); Fri, 22 Jul 2022 14:51:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232098AbiGVSvK (ORCPT ); Fri, 22 Jul 2022 14:51:10 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE7E712745 for ; Fri, 22 Jul 2022 11:51:08 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id y8so6901937eda.3 for ; Fri, 22 Jul 2022 11:51:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iEc3QibtkQB1h4TtSqccZQnGVDITp8oWtoE0M/00VQk=; b=GpGH7+7RBNLB4ERAP5aPNGUstRTGng8DobHWVI1kDtI0OXjU+zZIufvP7GM94p1RFJ Myu8OlHivlzSydD/yaZ4v2YbkeW2OOeevQCe5edKJhXpPh6YkH1n9zonI/fcGGjRCznc Z+YE9k7C1WrLsZHyQ+/d0FFuR9tzVhv782GgGH8Fk6jWQEBCDjSlkrItxuiY3Ky5v0YO /9DtwklLtYkRHdf99m3UqvP4wpNX/xz4xvJJrGEdhaH/CT0ZdZQcYrOjA4dvVfmHQlPe T+AxH6WI2WryCstt8r5eUbP+AjshGuvUYv+5lZssHJaS7KPlcjr6sCp+T9/5qurkXfY9 Jv0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iEc3QibtkQB1h4TtSqccZQnGVDITp8oWtoE0M/00VQk=; b=TydlGC3voFmZur2CFZpHqawxofjipYA+9h7/M4XZcT4WdbP90EYuZW8o0WsIDf907a RPl90z0XdGUgXK0QdNWcR4z9h7sUJsuQJk1L+ysF5/6RHMxJVPyPYODUWjWxnTMGG6H1 hjAXMxDQlDrCx2v8aDwgHTXrWR0g8EIL3wAeMPjB7e72KzkvzCk1MBCIa+fgP2J6Mvry 6NdBpyBzJvlH14DaQJNihGYvG/NFO3XZJ+f8l6Fr5/5NFoawCv/D+XCfQMNntoJ3YSEK liVYkFOTpjoxXFaI5wEaiCpmicBQwOexdoCj1loJQKxL+/L5B8mV8pXewd+mmD9Oucul wdtA== X-Gm-Message-State: AJIora+TdGoym1oaLW+4+IR7drWhFce1F9X3zeqkTEnO85OVU6zsT8wU zVhC8WfQlfo3m/rLkrbljM8= X-Google-Smtp-Source: AGRyM1tXdMIUQgykOTSlieMCzsF5hlEiszoOa249GdZLeCLe64pZ9bUR1e5zamycMiPMGKC7VcLVeQ== X-Received: by 2002:a05:6402:1e8c:b0:43a:c57f:2cbb with SMTP id f12-20020a0564021e8c00b0043ac57f2cbbmr1240037edf.97.1658515867058; Fri, 22 Jul 2022 11:51:07 -0700 (PDT) Received: from ?IPV6:2003:c7:8f2e:6976:6ec9:79b2:9979:d758? (p200300c78f2e69766ec979b29979d758.dip0.t-ipconnect.de. [2003:c7:8f2e:6976:6ec9:79b2:9979:d758]) by smtp.gmail.com with ESMTPSA id ti4-20020a170907c20400b0072faba59dd1sm905617ejc.165.2022.07.22.11.51.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 11:51:06 -0700 (PDT) Message-ID: Date: Fri, 22 Jul 2022 20:51:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4] staging: r8188eu: Inserted empty line after declarations Content-Language: en-US To: Abhijeet Srivastava Cc: Larry Finger , Phillip Potter , Pavel Skripkin , Greg Kroah-Hartman , Michael Straube , Rebecca Mckeever , Martin Kaiser , Vihas Makwana , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: <20220722161744.14914-1-abhijeet.srivastava2308@gmail.com> From: Philipp Hortmann In-Reply-To: <20220722161744.14914-1-abhijeet.srivastava2308@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/22/22 18:16, Abhijeet Srivastava wrote: > Warning found by checkpatch.pl script. Empty line missing. > Signed-off-by: Abhijeet Srivastava > --- > v2: > - Fix my name on the patch > v3: > - Fix commit message > v4: > - Fix body of explanation I would like to give you a reviewed by but now the empty line above the Signed-off is missing. Please have a look at the canonical patch format. Regards, Philipp