From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Khadija Kamran <kamrankhadijadj@gmail.com>,
outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Jerry Chuang <jerry-chuang@realtek.com>
Subject: Re: [PATCH v3 4/4] staging: rtl8192u: add '*/' on separate line in block comments
Date: Tue, 28 Mar 2023 15:48:42 +0700 [thread overview]
Message-ID: <fb1352ba-69a8-c1cc-7d72-43836f412e3d@gmail.com> (raw)
In-Reply-To: <ZCJ2_PuvCUBvlwaL@kroah.com>
On 3/28/23 12:11, Greg KH wrote:
>> While at above can you please turn these comments above into kernel-doc
>> comments (see Documentation/doc-guide/kernel-doc.rst for how to write
>> one)? This requires a placeholder doc where you can write e.g. overview
>> of the driver and how it is used. The doc should be in
>> Documentation/driver-api/staging/ (since this is staging driver).
>
> No, these are static functions, or just normal internal-to-the-driver
> functions, they do not need kerneldoc or any Documentation/* entries,
> sorry.
>
Ah! I don't see the context behind the comments, thanks anyway!
--
An old man doll... just what I always wanted! - Clara
prev parent reply other threads:[~2023-03-28 8:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 19:49 [PATCH v3 0/4] staging: rtl8192u: clean up comments in r8192U_dm.c Khadija Kamran
2023-03-27 19:49 ` [PATCH v3 1/4] staging: rtl8192u: remove change history from comments Khadija Kamran
2023-03-28 3:17 ` Bagas Sanjaya
2023-03-28 5:14 ` Julia Lawall
2023-03-27 19:49 ` [PATCH v3 2/4] staging: rtl8192u: remove commented out code Khadija Kamran
2023-03-27 19:49 ` [PATCH v3 3/4] staging: rtl8192u: add '*' on subsequent lines in block comment Khadija Kamran
2023-03-27 19:49 ` [PATCH v3 4/4] staging: rtl8192u: add '*/' on separate line in block comments Khadija Kamran
2023-03-28 3:27 ` Bagas Sanjaya
2023-03-28 5:11 ` Greg KH
2023-03-28 8:48 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb1352ba-69a8-c1cc-7d72-43836f412e3d@gmail.com \
--to=bagasdotme@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jerry-chuang@realtek.com \
--cc=kamrankhadijadj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox