From: Merlijn Wajer <merlijn@wizzup.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Ivaylo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Dev Null" <devnull@uvos.xyz>, "Tony Lindgren" <tony@atomide.com>,
"Sebastian Reichel" <sre@kernel.org>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
linux-omap@vger.kernel.org, "Dan Murphy" <dmurphy@ti.com>,
devicetree@vger.kernel.org, "Doug Zobel" <dougdev334@gmail.com>,
"Jacek Anaszewski" <jacek.anaszewski@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Sicelo A . Mhlongo" <absicsz@gmail.com>,
"Benoît Cousson" <bcousson@baylibre.com>
Subject: Re: [PATCH 0/2] Fix RGB status LED and keyboard backlight LEDs on Nokia N900
Date: Thu, 16 Dec 2021 12:51:28 +0100 [thread overview]
Message-ID: <fb433210-e0e7-908c-eb0d-e4e58691368a@wizzup.org> (raw)
In-Reply-To: <20211215203259.GF28336@duo.ucw.cz>
Hi Pavel,
On 15/12/2021 21:32, Pavel Machek wrote:
> Hi!
>
>> The RGB status LED and keyboard backlight LEDs were broken on the Nokia N900
>> since the conversion to gpiod descriptors and additionally later on with the
>> addition of multi color support. There was at least one attempt merged to fix
>> the lp5523 driver since the gpiod conversion, but it doesn't honour the device
>> tree, which in the case of the Nokia N900 means that the fix doesn't work.
>>
>> In this series are two patches fix the problems:
>>
>> * One addresses the gpiod change in the device tree as well as the multi
>> color support in the device tree;
>> * The other patch fixes the previous attempt at fixing the driver to honour
>> the device tree;
>>
>> Please let me know if anything seems off, and I'll be glad to make any
>> recommended changes, thanks!
>
> Thank you, I took the series. But if it changes the names in
> /sys/class/leds, we want to do something else.
Thanks -- just for the record (I already replied to the other email) -
the names do not change based on my testing.
Regards,
Merlijn
prev parent reply other threads:[~2021-12-16 11:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-12 22:40 [PATCH 0/2] Fix RGB status LED and keyboard backlight LEDs on Nokia N900 Merlijn Wajer
2021-12-12 22:40 ` [PATCH 1/2] ARM: dts: omap3-n900: Fix lp5523 for multi color Merlijn Wajer
2021-12-15 20:31 ` Pavel Machek
2021-12-16 11:50 ` Merlijn Wajer
2021-12-12 22:40 ` [PATCH 2/2] leds: lp55xx: initialise output direction from dts Merlijn Wajer
2021-12-12 23:59 ` Linus Walleij
2021-12-15 20:32 ` [PATCH 0/2] Fix RGB status LED and keyboard backlight LEDs on Nokia N900 Pavel Machek
2021-12-16 11:51 ` Merlijn Wajer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb433210-e0e7-908c-eb0d-e4e58691368a@wizzup.org \
--to=merlijn@wizzup.org \
--cc=absicsz@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=devnull@uvos.xyz \
--cc=dmurphy@ti.com \
--cc=dougdev334@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox