From: "Zouwei (Samuel)" <zou_wei@huawei.com>
To: Quentin Perret <qperret@google.com>
Cc: "mingo@redhat.com" <mingo@redhat.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"bsegall@google.com" <bsegall@google.com>,
"mgorman@suse.de" <mgorman@suse.de>,
"bristot@redhat.com" <bristot@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 答复: [PATCH -next] sched/topology: Mark some symbols with static keyword
Date: Wed, 25 Nov 2020 01:31:50 +0000 [thread overview]
Message-ID: <fb49182853774d13b5dadb3d8ac8cce7@huawei.com> (raw)
In-Reply-To: <20201124132428.GA1067355@google.com>
Quentin,
Thanks for the review. I will send the v2 soon.
-----邮件原件-----
发件人: Quentin Perret [mailto:qperret@google.com]
发送时间: 2020年11月24日 21:24
收件人: Zouwei (Samuel) <zou_wei@huawei.com>
抄送: mingo@redhat.com; peterz@infradead.org; juri.lelli@redhat.com; vincent.guittot@linaro.org; dietmar.eggemann@arm.com; rostedt@goodmis.org; bsegall@google.com; mgorman@suse.de; bristot@redhat.com; linux-kernel@vger.kernel.org
主题: Re: [PATCH -next] sched/topology: Mark some symbols with static keyword
On Tuesday 24 Nov 2020 at 19:52:11 (+0800), Zou Wei wrote:
> Fix the following sparse warnings:
>
> kernel/sched/topology.c:211:1: warning: symbol 'sched_energy_mutex' was not declared. Should it be static?
> kernel/sched/topology.c:212:6: warning: symbol 'sched_energy_update' was not declared. Should it be static?
>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
I think this wants:
Fixes: 31f6a8c0a471 ("sched/topology,schedutil: Wrap sched domains rebuild")
But, with that:
Reviewed-by: Quentin Perret <qperret@google.com>
Thanks,
Quentin
prev parent reply other threads:[~2020-11-25 1:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 11:52 [PATCH -next] sched/topology: Mark some symbols with static keyword Zou Wei
2020-11-24 13:24 ` Quentin Perret
2020-11-25 1:31 ` Zouwei (Samuel) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb49182853774d13b5dadb3d8ac8cce7@huawei.com \
--to=zou_wei@huawei.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox