From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA3A3C433FE for ; Fri, 18 Feb 2022 20:32:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239484AbiBRUcp (ORCPT ); Fri, 18 Feb 2022 15:32:45 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:60172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235980AbiBRUcn (ORCPT ); Fri, 18 Feb 2022 15:32:43 -0500 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 460E832EC4 for ; Fri, 18 Feb 2022 12:32:26 -0800 (PST) Received: by mail-io1-xd2d.google.com with SMTP id c23so4225869ioi.4 for ; Fri, 18 Feb 2022 12:32:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OC/1gLj8YvBkQUZUrsbQXVRK4g0Fu/RGJXaLX/hTlIE=; b=VUYiRxl7QQYbQTzrhoI5VxmE1dxTzS+T3rXsSAxVrz0cjQGpiXzj0nj9SJlA/Tiipu jT7JCWmkgKGytpB+3pbmcXMnSKAmmgoorkrtcAdJ7WvEpcRIR47ZaxhN0ItkuEkNcnKf PWizezoRmX11NmsQ9ej6OoEbXNe3RiUi+Ff3c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OC/1gLj8YvBkQUZUrsbQXVRK4g0Fu/RGJXaLX/hTlIE=; b=UEVboegM3M8fYQKG50cQOEOJb+nYRkTSC0lsqxXERWzj4Mv6Olenp9zPZN8iCHvd1O v7l8VsY4z5YORid5faNK1A6ZVmOrxTbMQgYP0YGjLmQeynpl/uFWhawPmeWb2ZIpWAqx LRKjv0ciyeA77RFgWTp1pNelSfzx7V+oWO3S72QuInwM01xN1IgzrcO4aE3W0DEt5SzD OWsRBuYSr8BlhGuv7J+7qebXyGQUa/nYR1tlKWlW0CzwuKChdlCQ+fogMHlSACeUi9ve 1PqVNPioBxBIfRxYIEIgOtu13apPNfXxfrLT9sGJBsS/umTQBNmzzkrp2OVJ9O7NbuS4 g2LA== X-Gm-Message-State: AOAM533KODSQnwyflpj1GS/L/KfY7FQC37L4qipcTsHa8AFXFSip2dmT U/xaXmYHeBI8WnGmDbryeEMNtQ== X-Google-Smtp-Source: ABdhPJxcsC5WZ3meD4lZFBEjpZyxGnBOKuRaKCQS2yliGT78npKQinvgqDJK+vrAtBDCyd2ffoFHyQ== X-Received: by 2002:a05:6638:3043:b0:314:7ce2:4a6e with SMTP id u3-20020a056638304300b003147ce24a6emr6409294jak.258.1645216345652; Fri, 18 Feb 2022 12:32:25 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id k11sm4596618iob.23.2022.02.18.12.32.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Feb 2022 12:32:25 -0800 (PST) Subject: Re: [PATCH v3 4/5] selftests/resctrl: Change the default limited time to 120 seconds To: Shaopeng Tan , Fenghua Yu , Reinette Chatre , Shuah Khan Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20220216022641.2998318-1-tan.shaopeng@jp.fujitsu.com> <20220216022641.2998318-5-tan.shaopeng@jp.fujitsu.com> From: Shuah Khan Message-ID: Date: Fri, 18 Feb 2022 13:32:24 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220216022641.2998318-5-tan.shaopeng@jp.fujitsu.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/15/22 7:26 PM, Shaopeng Tan wrote: > When testing on a Intel(R) Xeon(R) Gold 6254 CPU @ 3.10GHz the resctrl > selftests fail due to timeout after exceeding the default time limit of > 45 seconds. On this system the test takes about 68 seconds. > Since the failing test by default accesses a fixed size of memory, the > execution time should not vary significantly between different environment. > A new default of 120 seconds should be sufficient yet easy to customize > with the introduction of the "settings" file for reference. > > Signed-off-by: Shaopeng Tan > --- > From the perspective of the kselftest framework, > a rule of "Don't take too long" is a concern. > To get some better informed opinions from kselftest audience, > I highlighted this change in the cover letter. > > I adopted most of Reinette's phrase from the discussion in patch v2 > to explain why 120s is appropriate for this test. > > tools/testing/selftests/resctrl/settings | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 tools/testing/selftests/resctrl/settings > > diff --git a/tools/testing/selftests/resctrl/settings b/tools/testing/selftests/resctrl/settings > new file mode 100644 > index 000000000000..6091b45d226b > --- /dev/null > +++ b/tools/testing/selftests/resctrl/settings > @@ -0,0 +1 @@ > +timeout=120 > This is fine. Reviewed-by: Shuah Khan thanks, -- Shuah