From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B4C5367F50 for ; Tue, 3 Feb 2026 20:09:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770149348; cv=none; b=uovB9UMkE6qlAVpsWCA75yd/iq+HNSSVigFrb850C19ASAI1q9pfEpk3V9FVRjl+rQ2aLQyqMpCZ3Q/+CyYXPKH45YEaSVjt93ZzPAbpTdWWCSedmgwQ7PKETavRWGpM6IvmvWJnImnaT8HP23JntM5u4uXtqQME50VmUrpxfe4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770149348; c=relaxed/simple; bh=KXmsqY+Yl9J6VC7C3sRoq5iSnXOF93yU2uJPTfo6GLs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NKX34qDfr38FyvzcoEgskh8F+hj9RsvHj3ATRkHyD8jMSMm0nNTmsViyETK6Tt7Pr77WAb7PwWOgtR0rOn09XbUpwgRarK5mZldK5HM6OXFD5kwKWcsJAM3igLl7MyEtxzf9wYI0wfzKDDXZnNJnQLLsFTzD9+0TKdfOEsPr6Hc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EKCY9pny; arc=none smtp.client-ip=209.85.216.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EKCY9pny" Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-35456fcb79cso8078a91.3 for ; Tue, 03 Feb 2026 12:09:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770149347; x=1770754147; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=tVQhqA97aNi4iwum9p1p2SwQkrduofkl+pPHMaPCBPM=; b=EKCY9pnyCnAXESn4UGgZ0nOZG3kiGfVHstEsfYvE+ptMkDRD0QcgRAvJcp+kvb1W3J TOrIqLUFES/nwzzvD9shzWxNQih0TBfeaikD4e5Tmxu1xq+SB999q/RMNHokk5p2DhiX oVqf5mpnxZiA4Pbrb9TIRo3cEeaH7+rAjdDGZQDBhUj3JETIUQtt/Log1qiMUrsOcO07 ci3HaCooruZFdSV82+E82fB8i3rU4s5w/CpLo4afUSWBKSS/v+VBCLYkdt0Yj6nM+44C qTG+BfjFU6alalAY3c56cYC3Ms6taxhVZ5SMWlX8PPxWybqrQRNXGdY80gBms/Gcw5u4 JGEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770149347; x=1770754147; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=tVQhqA97aNi4iwum9p1p2SwQkrduofkl+pPHMaPCBPM=; b=HzSiDq+X6aI7s+7DLIbcF4q1I5PQ5KEhT58TiYumhbxE6CTIWfp1noNUQXugB9GTxw WQrpkcmy3Qeu4JKwGqiwc/lLklx2O81CxVjbbgLZAE8BWnicKnJ8wMgyKPW7IbnCXcRK GtpAiAQBdkZOnZ6jLWdtkib+91pR0M+O0bJnQ54lLoLsnWZ9ALSjKLca7S4lDPIw44Fx HbbBTyMyGDAFLH2NzSNTSBoXwpv9k6SXzja0mzO8iK9AlYbHh9aqL6F0jJ2GJ8AIrFvt R/3jqihp+PWFbzN7HNhTVBWF2Uf4JzGfE3MzBCaR1m3Tdl6Pyv2GSVbv2iYrxRlgF0Ep pXkA== X-Forwarded-Encrypted: i=1; AJvYcCXqHiBLpyMIYOT6GzvPNPHC2Lui4+IR7wK4YZ6nH0eUmUabqcTWgPSvKCYseAtOKMy+TN8z9L0Ac9VOy8I=@vger.kernel.org X-Gm-Message-State: AOJu0YygKGmtwDG4lI5LW0DGYqR2tVlPxTxdWRyLK81lZgLSgRyK1gtm CSaiHb7+LxHQgSbzTXzTJ70c9XZAfLZ7S8gkbLAB/OWrm4RPdC/5ciu9 X-Gm-Gg: AZuq6aKfQ/8cTpTwjI2EvJnomnaMXE6dQftsaWeTgW4ys2mTd8nXDGDTY6hvIIWMtvL uJDrurn+pO8XkgNAu3eeWBjnglJ6/RlBj53j+q0XVjxe+yst34zEqNrIMUQkIS6jT+39eF2cdrs zAcSau4petvsbk8LIf2a1+z4T9lp1mYYvU5wX5YLxeAEUai36IBgdN3wWdQbIy/oc62lBR3Y6nT piF2Up2XL9tRAYecgFEL+uKTuHWr3gw/ob4CR7QNyjrRFagYpvOP8+P9iS5xG8zXtzpP4lQLYmI q65xVi02WNK3vExIQasA6Dhm0ofax659Xd1kn0VM/u5uHxklhXNZkXhPjxYzp/vpSPgXLjGSOZz vMCkCy63E4xOgFzoMlJ8eUbNIo+yPAHhwc4+JZHHWKlkUf1LM5oQ1IIgPfzKa1LvrOUEEwFQAQ3 HdYq2KQCc3PWDWJiqb9qAhohl+lwHjTDbMrcs= X-Received: by 2002:a17:90b:4c51:b0:32d:f352:f764 with SMTP id 98e67ed59e1d1-354870b1e6dmr395651a91.2.1770149346689; Tue, 03 Feb 2026 12:09:06 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35485b77664sm479374a91.0.2026.02.03.12.09.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 12:09:06 -0800 (PST) Sender: Guenter Roeck Date: Tue, 3 Feb 2026 12:09:05 -0800 From: Guenter Roeck To: victor.duicu@microchip.com Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, corbet@lwn.net, marius.cristea@microchip.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 2/2] hwmon: add support for MCP998X Message-ID: References: <20260127151823.9728-1-victor.duicu@microchip.com> <20260127151823.9728-3-victor.duicu@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260127151823.9728-3-victor.duicu@microchip.com> On Tue, Jan 27, 2026 at 05:18:22PM +0200, victor.duicu@microchip.com wrote: > From: Victor Duicu > > This is the driver for Microchip MCP998X/33 and MCP998XD/33D > Multichannel Automotive Temperature Monitor Family. > > Signed-off-by: Victor Duicu > --- More feedback, with compliments from Gemini :-). [ ... ] > + case hwmon_temp: > + switch (attr) { > + case hwmon_temp_max: > + if (channel) > + addr = MCP9982_EXT_HIGH_LIMIT_ADDR(channel); > + else > + addr = MCP9982_INTERNAL_HIGH_LIMIT_ADDR; > + > + return ret = mcp9982_write_limit(priv, addr, val); Pointless assignment to ret. Thanks, Guenter