From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fra-out-009.esa.eu-central-1.outbound.mail-perimeter.amazon.com (fra-out-009.esa.eu-central-1.outbound.mail-perimeter.amazon.com [3.64.237.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE79627B359; Wed, 14 Jan 2026 13:56:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=3.64.237.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768398985; cv=none; b=jGmofP7+sDvFFRTnts3Wr41w1ZM+PJ3iwXQdx4MmKDC4DLdkpJZO/JRLAuodtf3mQaWjXdJk+gWK1UgTgKH+5puYc8/FyQ7j5ezE6nhCMlXL5+joun8aJhi/qYmKDE+SnSTNZhY2AbVHxNR9AvCuz43+N6u9yTOuiZ0VBXrC8lE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768398985; c=relaxed/simple; bh=4jehppCxYZb3H+8US6e70OAhxSFdOGaFDcE1itzIo04=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=d/1Akemfzx8GRGIJ9oiSQTmOPwb4JU0UkMuczpac85/jCDmS/VkXUhDC4i9d0ceX2yqUzU75z3yYiiYYgVvOQ4WJ+EoMEnGMY41NkY3YrB48rlCR8PgIK9KDurR9RgaC8urfSXUHwdMWdVVZmdBoGjSB4JJboQNwcnED6OpAz9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.uk; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=CJJP8jk7; arc=none smtp.client-ip=3.64.237.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.uk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="CJJP8jk7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1768398983; x=1799934983; h=message-id:date:mime-version:reply-to:subject:to:cc: references:from:in-reply-to:content-transfer-encoding; bh=w3F8MUhrMvgRZFfwctnZ78oBfLCdFIOc7w3lcR0phs0=; b=CJJP8jk7vhR8U3I4lVZ9mbNDBfPYJWWoLzdxoiHTk6D13K7qorICvxqR g/SOG8Nra+0f1NVP3njXMZiiovymbh7KDIlfdFa1PcsvLzwqJ4XvhUYPq JRN/jr5cpRxNcpGW6C4h5FeYFOD07PzkzC69R0XqM3Ky7J0MG0sDWIA4w kGgiDpyajtbTFfzoqKKBvCG09QnJh6+5K/cizs5JnXRjXJwohRqL39A0i Ay86TWvHEWdQHVD5X7vvj9+2IN0jGl7VdIEi4lep/RP7PtQLpaaVhavUr iTznlfxvsqPp2cv6o+tvV0H65R8Dcojw4CRxFeFCJc6H+VEhKEPOOJWbT Q==; X-CSE-ConnectionGUID: XF6mHF4aS6GGlQcAbC9qng== X-CSE-MsgGUID: y7/KM2RDSRi2eZesrfDudA== X-IronPort-AV: E=Sophos;i="6.21,225,1763424000"; d="scan'208";a="7809379" Received: from ip-10-6-6-97.eu-central-1.compute.internal (HELO smtpout.naws.eu-central-1.prod.farcaster.email.amazon.dev) ([10.6.6.97]) by internal-fra-out-009.esa.eu-central-1.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jan 2026 13:56:17 +0000 Received: from EX19MTAEUB001.ant.amazon.com [54.240.197.234:26058] by smtpin.naws.eu-central-1.prod.farcaster.email.amazon.dev [10.0.37.91:2525] with esmtp (Farcaster) id 62e8fe80-349c-49ed-8e4f-57e1f40594af; Wed, 14 Jan 2026 13:56:17 +0000 (UTC) X-Farcaster-Flow-ID: 62e8fe80-349c-49ed-8e4f-57e1f40594af Received: from EX19D005EUB003.ant.amazon.com (10.252.51.31) by EX19MTAEUB001.ant.amazon.com (10.252.51.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Wed, 14 Jan 2026 13:56:15 +0000 Received: from [192.168.15.25] (10.106.82.12) by EX19D005EUB003.ant.amazon.com (10.252.51.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.35; Wed, 14 Jan 2026 13:56:12 +0000 Message-ID: Date: Wed, 14 Jan 2026 13:56:10 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Subject: Re: [PATCH v8 05/13] KVM: guest_memfd: Add flag to remove from direct map To: Dave Hansen , "Kalyazin, Nikita" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" CC: "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oupton@kernel.org" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "seanjc@google.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "david@kernel.org" , "lorenzo.stoakes@oracle.com" , "Liam.Howlett@oracle.com" , "vbabka@suse.cz" , "rppt@kernel.org" , "surenb@google.com" , "mhocko@suse.com" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "song@kernel.org" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jolsa@kernel.org" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "shuah@kernel.org" , "riel@surriel.com" , "baohua@kernel.org" , "ryan.roberts@arm.com" , "jgross@suse.com" , "yu-cheng.yu@intel.com" , "kas@kernel.org" , "coxu@redhat.com" , "kevin.brodsky@arm.com" , "ackerleytng@google.com" , "maobibo@loongson.cn" , "prsampat@amd.com" , "mlevitsk@redhat.com" , "isaku.yamahata@intel.com" , "jmattson@google.com" , "jthoughton@google.com" , "linux-arm-kernel@lists.infradead.org" , "vannapurve@google.com" , "jackmanb@google.com" , "aneesh.kumar@kernel.org" , "patrick.roy@linux.dev" , "Thomson, Jack" , "Itazuri, Takahiro" , "Manwaring, Derek" , "Cali, Marco" References: <20251205165743.9341-1-kalyazin@amazon.com> <20251205165743.9341-6-kalyazin@amazon.com> <51a059a1-f03a-4b43-8df6-d31fca09cce7@intel.com> Content-Language: en-US From: Nikita Kalyazin Autocrypt: addr=kalyazin@amazon.com; keydata= xjMEY+ZIvRYJKwYBBAHaRw8BAQdA9FwYskD/5BFmiiTgktstviS9svHeszG2JfIkUqjxf+/N JU5pa2l0YSBLYWx5YXppbiA8a2FseWF6aW5AYW1hem9uLmNvbT7CjwQTFggANxYhBGhhGDEy BjLQwD9FsK+SyiCpmmTzBQJnrNfABQkFps9DAhsDBAsJCAcFFQgJCgsFFgIDAQAACgkQr5LK IKmaZPOpfgD/exazh4C2Z8fNEz54YLJ6tuFEgQrVQPX6nQ/PfQi2+dwBAMGTpZcj9Z9NvSe1 CmmKYnYjhzGxzjBs8itSUvWIcMsFzjgEY+ZIvRIKKwYBBAGXVQEFAQEHQCqd7/nb2tb36vZt ubg1iBLCSDctMlKHsQTp7wCnEc4RAwEIB8J+BBgWCAAmFiEEaGEYMTIGMtDAP0Wwr5LKIKma ZPMFAmes18AFCQWmz0MCGwwACgkQr5LKIKmaZPNTlQEA+q+rGFn7273rOAg+rxPty0M8lJbT i2kGo8RmPPLu650A/1kWgz1AnenQUYzTAFnZrKSsXAw5WoHaDLBz9kiO5pAK In-Reply-To: <51a059a1-f03a-4b43-8df6-d31fca09cce7@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: EX19D015EUB004.ant.amazon.com (10.252.51.13) To EX19D005EUB003.ant.amazon.com (10.252.51.31) On 05/12/2025 17:30, Dave Hansen wrote: > On 12/5/25 08:58, Kalyazin, Nikita wrote: >> +static void kvm_gmem_folio_restore_direct_map(struct folio *folio) >> +{ >> + /* >> + * Direct map restoration cannot fail, as the only error condition >> + * for direct map manipulation is failure to allocate page tables >> + * when splitting huge pages, but this split would have already >> + * happened in set_direct_map_invalid_noflush() in kvm_gmem_folio_zap_direct_map(). >> + * Thus set_direct_map_valid_noflush() here only updates prot bits. >> + */ >> + if (kvm_gmem_folio_no_direct_map(folio)) >> + set_direct_map_valid_noflush(folio_page(folio, 0), folio_nr_pages(folio), >> + true); >> +} > > This is rather hopeful programming. > > I can think of a number of ways that this assumption might become invalid. > This at *least* check for set_direct_map_valid_noflush() failures (or > whatever interface you end up using)? > > A WARN_ON_ONCE() would be fine. Done in v9, thanks.