From: Steven Stewart-Gallus <sstewartgallus00@mylangara.bc.ca>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Davidlohr Bueso <davidlohr@hp.com>,
Manfred Spraul <manfred@colorfullife.com>,
"J. Bruce Fields" <bfields@redhat.com>,
Doug Ledford <dledford@redhat.com>,
linux-newbie@vger.kernel.org
Subject: Re: [PATCH 1/1] ipc/mqueue.c: Drag unneeded code out of locks
Date: Sat, 15 Nov 2014 04:42:34 +0000 (GMT) [thread overview]
Message-ID: <fb7fa4d76314.5466d9ba@langara.bc.ca> (raw)
In-Reply-To: <20141111162146.6e72c3fb0858df4945096c47@linux-foundation.org>
Hello, thank you for the criticism.
> It's probably better to do this as three or four separate patches.
Really? Alright if you insist I'll do the next version as multiple
patches.
> Well yes, that's what EMFILE means but "too_many_open_files" doesn't
> make sense in this context!
Fair enough, I'll rename it in the next version.
> Thatsabug. It only requires CAP_SYS_RESOURCE if we're trying with
> queues_count >= queues_max.
Right, that was dumb of me.
> This test isn't really needed.
I don't follow. If the queue creation is not rejected then the
resource user has to be accounted for right? And we can't add the
resource to accounting if it is not created right?
Thank you,
Steven Stewart-Gallus
next prev parent reply other threads:[~2014-11-15 5:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 5:40 [PATCH 1/1] ipc/mqueue.c: Drag unneeded code out of locks Steven Stewart-Gallus
2014-11-12 0:21 ` Andrew Morton
2014-11-15 4:42 ` Steven Stewart-Gallus [this message]
2014-11-12 8:16 ` Davidlohr Bueso
2014-11-15 4:44 ` Steven Stewart-Gallus
2014-11-15 21:22 ` Davidlohr Bueso
2014-11-16 19:40 ` Steven Stewart-Gallus
2014-11-17 19:08 ` Manfred Spraul
2014-11-17 20:52 ` Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fb7fa4d76314.5466d9ba@langara.bc.ca \
--to=sstewartgallus00@mylangara.bc.ca \
--cc=akpm@linux-foundation.org \
--cc=bfields@redhat.com \
--cc=davidlohr@hp.com \
--cc=dledford@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-newbie@vger.kernel.org \
--cc=manfred@colorfullife.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox