Re: [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

Guenter Roeck
2018-05-23T16:30:00Z

On Wed, May 23, 2018 at 6:54 AM Takashi Iwai <tiwai@suse.de> wrote:

> On Tue, 22 May 2018 18:58:42 +0200,
> Guenter Roeck wrote:
> >
> > +struct skl_dfw_v4_module_caps {
> > + u32 set_params:2;
> > + u32 rsvd:30;
> > + u32 param_id;
> > + u32 caps_size;
> > + u32 caps[HDA_SST_CFG_MAX];
> > +};

> Missing __packed attribute?

Yes and no. The original structure (see
sound/soc/intel/skylake/skl-tplg-interface.h
in v4.5.y and earlier) doesn't have the __packed attribute either. I guess
it doesn't hurt,
since it is all u32, so I'll add it in.

Guenter

> And I'm wondering whether we should move these definitions to uapi
> headers.

> thanks,

> Takashi