From: MD Danish Anwar <danishanwar@ti.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>, Roger Quadros <rogerq@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
Richard Cochran <richardcochran@gmail.com>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
<vladimir.oltean@nxp.com>, Simon Horman <horms@kernel.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<srk@ti.com>, <r-gunasekaran@ti.com>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Roger Quadros <rogerq@ti.com>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>
Subject: Re: [EXTERNAL] Re: [PATCH net-next v3] net: ti: icssg_prueth: add TAPRIO offload support
Date: Thu, 5 Oct 2023 11:10:00 +0530 [thread overview]
Message-ID: <fba767da-ae4d-9fb8-b637-955363a57540@ti.com> (raw)
In-Reply-To: <20231004135833.6efdbced@kernel.org>
On 05/10/23 02:28, Jakub Kicinski wrote:
> On Thu, 28 Sep 2023 16:00:00 +0530 MD Danish Anwar wrote:
>> +/**
>> + * Config state machine variables. See IEEE Std 802.1Q-2018 8.6.8.4
>> + */
>
> Please use correct kdoc format with all members documented or not use
> the /** marker.
>
Sure. I will update the documentation with correct kdoc format.
>> +struct tas_config_list {
>> + /* New list is copied at this time */
>> + u64 config_change_time;
>> + /* config change error counter, incremented if
>> + * admin->BaseTime < current time and TAS_enabled is true
>> + */
>> + u32 config_change_error_counter;
>> + /* True if list update is pending */
>> + u8 config_pending;
>> + /* Set to true when application trigger updating of admin list
>> + * to active list, cleared when configChangeTime is updated
>> + */
>> + u8 config_change;
>> +};
--
Thanks and Regards,
Danish
prev parent reply other threads:[~2023-10-05 16:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 10:30 [PATCH net-next v3] net: ti: icssg_prueth: add TAPRIO offload support MD Danish Anwar
2023-09-30 2:37 ` Vinicius Costa Gomes
2023-10-02 16:35 ` Roger Quadros
2023-10-04 20:58 ` Jakub Kicinski
2023-10-05 5:40 ` MD Danish Anwar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fba767da-ae4d-9fb8-b637-955363a57540@ti.com \
--to=danishanwar@ti.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=richardcochran@gmail.com \
--cc=rogerq@kernel.org \
--cc=rogerq@ti.com \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
--cc=vinicius.gomes@intel.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox