Re: [PATCH 2/4] regulator: dt-bindings: Add pm8008 regulator bindings

Mark Brown
2021-09-17T15:49:12Z

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

On Fri, Sep 17, 2021 at 04:15:36PM +0530, Satya Priya wrote:

> + properties:
> + reg:
> + maxItems: 1
> + regulator-name: true
> + regulator-min-microvolt: true
> + regulator-max-microvolt: true

You shouldn't be forcing these properties, it should be perfectly OK for
boards to have fixed voltages especially for example during bringup or
for debugging.

> + qcom,min-dropout-voltage:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Specifies the minimum voltage in microvolts that the parent
> + supply regulator must output, above the output of this
> + regulator.

If this is needed in DT it should be a generic property since most
regulators have some requirement here however usually it's a fixed
property of the silicon and should therefore just gets set in the
regulator_desc as min_dropout_uV - I'd strongly recommend having a
default there even if there's some requirement for it to be set per
board.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]