Re: [PATCH 1/4] dt-bindings: mfd: pm8008: Add pm8008 regulator node

skakit
2021-09-28T12:32:04Z

On 2021-09-21 01:02, Stephen Boyd wrote:
> Quoting Satya Priya (2021-09-17 03:45:35)
>> Add pm8008-regulator node and example.
>>
>> Signed-off-by: Satya Priya <skakit@codeaurora.org>
>> ---
>> .../devicetree/bindings/mfd/qcom,pm8008.yaml | 24
>> ++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
>> b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
>> index ec3138c..de182f8 100644
>> --- a/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/qcom,pm8008.yaml
>> @@ -45,6 +45,10 @@ properties:
>> const: 0
>>
>> patternProperties:
>> + "^pm8008[a-z]?-regulator$":
>
> Shouldn't it be ^pm8008-regulator$ without the a-z optional letter?
>

Some platforms use 2 PM8008 PMICS, in that case we need suffixing like
pm8008i pm8008j etc. So, I mentioned this way.

>> + type: object
>> + $ref: "../regulator/qcom,pm8008-regulator.yaml#"
>> +
>> "^gpio@[0-9a-f]+$":
>> type: object
>>