Re: Build error in 6.16-rc1 in drivers/mfd/88pm860x-core.c

Peter Schneider
2025-06-09T02:58:55Z

Am 09.06.2025 um 04:31 schrieb Mario Limonciello:

>
> On 6/8/25 8:58 PM, Peter Schneider wrote:
>>
>> I'm not a Kernel developer nor a C programmer, I only have superficial knowledge of C
>> (but I love to test and to tinker), so I don't quite understand this warning/error
>> message. Becauses some lines below, the node variable is used as a paramter to the
>> of_fwnode_handle macro (from include/linux/of.h):
>>
>>          irq_domain_create_legacy(of_fwnode_handle(node), nr_irqs, chip-  >irq_base, 0,
>>                                   &pm860x_irq_domain_ops, chip);
>>
>> Does that not count as variable usage to the compiler?
> It's not because there is a macro when CONFIG_OF is not defined that assigns it as NULL.
> So to the compiler there is no variable use.

Ah, thanks for the explanation! I didn't quite see and grasp the nested #ifdefs depending
on CONFIG_OF and the alternate macro definition for of_fwnode_handle when CONFIG_OF is not
set. Now as I do, it makes perfect sense.

Beste Grüße,
Peter Schneider

--
Climb the mountain not to plant your flag, but to embrace the challenge,
enjoy the air and behold the view. Climb it so you can see the world,
not so the world can see you. -- David McCullough Jr.

OpenPGP: 0xA3828BD796CCE11A8CADE8866E3A92C92C3FF244
Download: https://www.peters-netzplatz.de/download/pschneider1968_pub.asc