From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FF814399E5 for ; Mon, 24 Aug 2026 14:23:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787581412; cv=none; b=R6XLDDMTo5Yam8czh6LcY7ALlouUMAVHSQkCzB1uK4hFW/9X9+CCIju4KYrAa/UihvlXTVfvhT4saicwRRKlEUkawdw7C4wD1MmvcKL+S4s+SjAyK3zsPNZPCaKLskQRJuMf/qVELvK2zd/LoEqGTp2pWneAZ+sIF9O5c6E9D84= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787581412; c=relaxed/simple; bh=6kB5h1HEECPTicOG3LYyogzNQExsOtWLu7kTMzR5cg0=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=JoKT1PdiQ7FRO0z90jCXgGrsLGfTXwXbw3KzthwaV+ce/UEBxVsUpBe7+lAWwpkmJ7AqLn85K+KC1J+CqwbNglOESGvS336P44d0xlLgTuc0FihTMiIy4AgYzQk/Dp4IFsl9CEA1rKiz0OSUH3aa4v93fN1r8/NNFBi1l8QW8T8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qTL5iIIU; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qTL5iIIU" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-836c590b61eso53213617b3.0 for ; Mon, 24 Aug 2026 07:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1787581409; x=1788186209; darn=vger.kernel.org; h=content-type:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DAA3AJBckMfL7iDkU5H4UAChzqupIeoXexgfVyLiXUk=; b=qTL5iIIUHVBB9JoHNIpqnDPZ8Tgfan4sEu+QR0jdnehPcdRuSmmSwrTk5iczR8q5DD 600sh1DTir0FNM08emH2W9KFR+c5JnQvIJhyb3T26Cw4B38BIWghn22vvykMM45M388U bJnjrkF6MAh4c/yHo3+o/t/uMp88ct+95h8a6fHmgzcnDUYnTD7ZsU5oDvccIbAxwtl2 WXjIvy7nmjcYv7IeJhvfOCQdnexTlqMx+eN9GT5NvTXc1Pu3tbLAzS6FYPxnkxx6+ZSN Op/Oam74dLn3ZBLZnFPzkvHBG35ayFwnOvUGHFjjlvN6wqCLJ/YOlwnFTazDqJ9O/4LZ BUig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787581409; x=1788186209; h=content-type:mime-version:references:message-id:in-reply-to:subject :cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DAA3AJBckMfL7iDkU5H4UAChzqupIeoXexgfVyLiXUk=; b=PBv39dsYhkp4lxm5Jq21S7hHwQI4QLWrskTOexhHZQNmYKPCwlbMs4xKFr+3DUXvwZ TEQ/aVYr86Mze01AimczUSGiyZfkJ/I7Z3M5/NaKsWfWUmxQTpbm5p2Cy+Q27k8TqlM7 7k+fJxzKAOyc075Gzg16uFtEuGUbdyDQfgdWHFlV7R3G4+7TEmZML0vSJztw+GnchlP/ zCcVo3sP+LNoLlYqWzFbMY42SbdfvCwVqE7IHneVZdOs8QJSSEStxJsVIONbxmJ+JI+k dqE7ayw+4f+PJSoJcTt3bgQSTKzlcp7Iir7Fd6YwXB31OYFQ1ypyMXhs+om8jlSAd+2f HiYQ== X-Forwarded-Encrypted: i=1; AHgh+RoCWuVx9ezigvx7UDnmLP/Vto719Cotgs6Ni5/jcoR+5ZY4DbZ+Nq82K/yP4RBnWxOkPxaPiXaOG2arIzA=@vger.kernel.org X-Gm-Message-State: AFuF++nP8dA+0tGRAiRBqThdCM1y7aQuud7+wDHqqWIU7PRVYsj8ype4 U3ho7RqMTuWZGh1y1CM3mpcxkAvFZN9G1GlXEQDQqMPqNi4Ix1UoujymFgEOr+7Jew== X-Gm-Gg: AR+sD11vS5MIyq9vWcW/XP0a/2IcxsgzeNq0AbJZnpsQROzWcKLRlcRscmpctQSbvS7 QXsDM2aDbAWwK7CzXx7l80tio5CZC7bQ8d72x1HqeowD6A3oabIAhx3X1aAKrD/ywY0ggrBsg1Z /uJleALyxpkgc0YE/BF44omboWdLCYLmO2jikBpJWVPWXM8eREZNT5TYtQ2oRAvu+e+F5RQGjfF kpFxbivPEeZhv+3+VKGotyHC0VHcPqZNs2ji2PU0Hk0WR8JQ5P4v8KYusU3xAypwWAnn++yZT01 4bQ5FXfJcDx1Oa3bxCBJYsyFAZiWUKRKeHqlPJw7mS+mNXCjv8CcJ65UmE5iazrdUkP0qSqkul2 w5HBTlGYIc14YifX39mIjDud2glH4FsuCO/EIW0JSy9XYn7xUQogswAIRemJZNhS0TP2HR45n6T JsJujufXsWFJrNbcontK+iJQ//RpQCNzUeN2n7Jx4sOOKSwSdJJW36fdAopPofYmrUOLvBbF/g8 k1FMN38irMk42yADa/WL+KTaTUBtnEZ9Fh/DmY3Sz7v1KGu X-Received: by 2002:a05:690c:a4db:b0:80d:a249:4854 with SMTP id 00721157ae682-84c99f902c3mr43542587b3.17.1787581408945; Mon, 24 Aug 2026 07:23:28 -0700 (PDT) Received: from darker.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id 00721157ae682-84cab854483sm33838647b3.33.2026.08.24.07.23.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 07:23:27 -0700 (PDT) Date: Mon, 24 Aug 2026 07:23:23 -0700 (PDT) From: Hugh Dickins To: Andrew Morton cc: Ackerley Tng , Alexander Viro , Baolin Wang , Barry Song , Binbin Wu , Christian Brauner , Christoph Hellwig , Christoph Lameter , Claudio Imbrenda , David Hildenbrand , JP Kobryn , Jan Kara , Jens Axboe , Johannes Weiner , Kairui Song , Kiryl Shutsemau , Lance Yang , Leonardo Bras , Lorenzo Stoakes , Marcelo Tosatti , Matthew Wilcox , Mel Gorman , Miaohe Lin , Michal Hocko , Minchan Kim , Muchun Song , Oscar Salvador , Peter Zijlstra , Qi Zheng , Rik van Riel , Sebastian Andrzej Siewior , Shakeel Butt , Suren Baghdasaryan , Vlastimil Babka , Yang Shi , Yu Zhao , Zach O'Keefe , Zi Yan , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 13/25] mm/fbatch: no lru_add_drain() to collect_longterm_unpinnable_folios() In-Reply-To: <14a16945-529b-8bc0-ab38-3ea97e54e223@google.com> Message-ID: References: <14a16945-529b-8bc0-ab38-3ea97e54e223@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII collect_longterm_unpinnable_folios() has no use for lru_add_drain() nor lru_add_drain_all(), now that the per-cpu fbatch references are gone. Signed-off-by: Hugh Dickins --- mm/gup.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 99902c15703b..9616379ab069 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -2268,7 +2268,6 @@ static unsigned long collect_longterm_unpinnable_folios( { unsigned long collected = 0; struct folio *folio; - int drained = 0; long i = 0; for (folio = pofs_get_folio(pofs, i); folio; @@ -2287,19 +2286,6 @@ static unsigned long collect_longterm_unpinnable_folios( continue; } - if (drained == 0 && folio_may_be_lru_cached(folio) && - folio_ref_count(folio) != - folio_expected_ref_count(folio) + 1) { - lru_add_drain(); - drained = 1; - } - if (drained == 1 && folio_may_be_lru_cached(folio) && - folio_ref_count(folio) != - folio_expected_ref_count(folio) + 1) { - lru_add_drain_all(); - drained = 2; - } - if (!folio_isolate_lru(folio)) continue; -- 2.51.0