From: Jeff Layton <jlayton@kernel.org>
To: "Luís Henriques" <lhenriques@suse.de>,
"Xiubo Li" <xiubli@redhat.com>,
"Ilya Dryomov" <idryomov@gmail.com>
Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ceph: fix error path in ceph_readdir()
Date: Fri, 04 Mar 2022 13:17:24 -0500 [thread overview]
Message-ID: <fbf5211f69b5cda372c90d78c6aeee00524fcfbf.camel@kernel.org> (raw)
In-Reply-To: <20220304161403.19295-2-lhenriques@suse.de>
On Fri, 2022-03-04 at 16:14 +0000, Luís Henriques wrote:
> This was introduced by commit
>
> "ceph: add support to readdir for encrypted filenames"
>
> It will eventually leak the fscrypt_str names in this error path.
>
> Signed-off-by: Luís Henriques <lhenriques@suse.de>
> ---
> fs/ceph/dir.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c
> index 44395aae7259..0bcb677d2199 100644
> --- a/fs/ceph/dir.c
> +++ b/fs/ceph/dir.c
> @@ -500,7 +500,6 @@ static int ceph_readdir(struct file *file, struct dir_context *ctx)
> next_offset);
> if (err) {
> ceph_mdsc_put_request(dfi->last_readdir);
> - return err;
> goto out;
> }
> } else if (req->r_reply_info.dir_end) {
This doesn't seem to apply to the current wip-fscrypt tree. Are you
working against an older branch, perhaps?
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2022-03-04 18:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 16:14 [PATCH 0/3] ceph: minor fixes and encrypted snapshot names Luís Henriques
2022-03-04 16:14 ` [PATCH 1/3] ceph: fix error path in ceph_readdir() Luís Henriques
2022-03-04 18:17 ` Jeff Layton [this message]
2022-03-05 14:30 ` Luís Henriques
2022-03-04 16:14 ` [PATCH 2/3] ceph: fix use-after-free in ceph_readdir Luís Henriques
2022-03-04 18:20 ` Jeff Layton
2022-03-05 12:43 ` Xiubo Li
2022-03-05 14:32 ` Luís Henriques
2022-03-04 16:14 ` [PATCH 3/3] ceph: add support for encrypted snapshot names Luís Henriques
2022-03-04 18:25 ` Jeff Layton
2022-03-05 14:34 ` Luís Henriques
2022-03-05 12:43 ` Xiubo Li
2022-03-04 16:26 ` [PATCH 0/3] ceph: minor fixes and " Luís Henriques
2022-03-04 18:30 ` Jeff Layton
2022-03-05 14:56 ` Luís Henriques
2022-03-07 0:49 ` Xiubo Li
2022-03-07 14:20 ` Luís Henriques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fbf5211f69b5cda372c90d78c6aeee00524fcfbf.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=lhenriques@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox