[PATCH] cpufreq/amd-pstate: Add the missing cpufreq_cpu_put()

[PATCH] cpufreq/amd-pstate: Add the missing cpufreq_cpu_put()

[Dhananjay Ugwekar]

Fix the reference counting of cpufreq_policy object in amd_pstate_update()
function by adding the missing cpufreq_cpu_put().

Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
---
 drivers/cpufreq/amd-pstate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
index 804fab4ebb26..36edae40db1a 100644
--- a/drivers/cpufreq/amd-pstate.c
+++ b/drivers/cpufreq/amd-pstate.c
@@ -560,6 +560,8 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf,
 
 	amd_pstate_update_perf(cpudata, min_perf, des_perf,
 			       max_perf, fast_switch);
+
+	cpufreq_cpu_put(policy);
 }
 
 static int amd_pstate_verify(struct cpufreq_policy_data *policy)
-- 
2.34.1

Re: [PATCH] cpufreq/amd-pstate: Add the missing cpufreq_cpu_put()

[Dhananjay Ugwekar]

Forgot the fixes tag,

On 7/31/2024 2:02 PM, Dhananjay Ugwekar wrote:
> Fix the reference counting of cpufreq_policy object in amd_pstate_update()
> function by adding the missing cpufreq_cpu_put().
>

Fixes: e8f555daacd3 ("cpufreq/amd-pstate: fix setting policy current frequency value")

Thanks,
Dhananjay
> Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
> ---
>  drivers/cpufreq/amd-pstate.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 804fab4ebb26..36edae40db1a 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -560,6 +560,8 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf,
>  
>  	amd_pstate_update_perf(cpudata, min_perf, des_perf,
>  			       max_perf, fast_switch);
> +
> +	cpufreq_cpu_put(policy);
>  }
>  
>  static int amd_pstate_verify(struct cpufreq_policy_data *policy)

RE: [PATCH] cpufreq/amd-pstate: Add the missing cpufreq_cpu_put()

[Yuan, Perry]

[AMD Official Use Only - AMD Internal Distribution Only]

Hi Dhananjay

> -----Original Message-----
> From: Ugwekar, Dhananjay <Dhananjay.Ugwekar@amd.com>
> Sent: Wednesday, July 31, 2024 4:39 PM
> To: Huang, Ray <Ray.Huang@amd.com>; Shenoy, Gautham Ranjal
> <gautham.shenoy@amd.com>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; Yuan, Perry <Perry.Yuan@amd.com>;
> rafael@kernel.org; viresh.kumar@linaro.org
> Cc: linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] cpufreq/amd-pstate: Add the missing cpufreq_cpu_put()
>
> Forgot the fixes tag,
>
> On 7/31/2024 2:02 PM, Dhananjay Ugwekar wrote:
> > Fix the reference counting of cpufreq_policy object in
> > amd_pstate_update() function by adding the missing cpufreq_cpu_put().
> >
>
> Fixes: e8f555daacd3 ("cpufreq/amd-pstate: fix setting policy current
> frequency value")
>
> Thanks,
> Dhananjay
> > Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
> > ---
> >  drivers/cpufreq/amd-pstate.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/cpufreq/amd-pstate.c
> > b/drivers/cpufreq/amd-pstate.c index 804fab4ebb26..36edae40db1a
> 100644
> > --- a/drivers/cpufreq/amd-pstate.c
> > +++ b/drivers/cpufreq/amd-pstate.c
> > @@ -560,6 +560,8 @@ static void amd_pstate_update(struct amd_cpudata
> > *cpudata, u32 min_perf,
> >
> >     amd_pstate_update_perf(cpudata, min_perf, des_perf,
> >                            max_perf, fast_switch);
> > +
> > +   cpufreq_cpu_put(policy);
> >  }
> >
> >  static int amd_pstate_verify(struct cpufreq_policy_data *policy)

Thanks for the fix,   it needs to send v2 with the Fixes tag.

Reviewed-by: Perry Yuan <perry.yuan@amd.com>

Best Regards.

Perry.

Re: [PATCH] cpufreq/amd-pstate: Add the missing cpufreq_cpu_put()

[Dhananjay Ugwekar]

On 8/1/2024 8:43 AM, Yuan, Perry wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
> 
> Hi Dhananjay
> 
>> -----Original Message-----
>> From: Ugwekar, Dhananjay <Dhananjay.Ugwekar@amd.com>
>> Sent: Wednesday, July 31, 2024 4:39 PM
>> To: Huang, Ray <Ray.Huang@amd.com>; Shenoy, Gautham Ranjal
>> <gautham.shenoy@amd.com>; Limonciello, Mario
>> <Mario.Limonciello@amd.com>; Yuan, Perry <Perry.Yuan@amd.com>;
>> rafael@kernel.org; viresh.kumar@linaro.org
>> Cc: linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH] cpufreq/amd-pstate: Add the missing cpufreq_cpu_put()
>>
>> Forgot the fixes tag,
>>
>> On 7/31/2024 2:02 PM, Dhananjay Ugwekar wrote:
>>> Fix the reference counting of cpufreq_policy object in
>>> amd_pstate_update() function by adding the missing cpufreq_cpu_put().
>>>
>>
>> Fixes: e8f555daacd3 ("cpufreq/amd-pstate: fix setting policy current
>> frequency value")
>>
>> Thanks,
>> Dhananjay
>>> Signed-off-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
>>> ---
>>>  drivers/cpufreq/amd-pstate.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/cpufreq/amd-pstate.c
>>> b/drivers/cpufreq/amd-pstate.c index 804fab4ebb26..36edae40db1a
>> 100644
>>> --- a/drivers/cpufreq/amd-pstate.c
>>> +++ b/drivers/cpufreq/amd-pstate.c
>>> @@ -560,6 +560,8 @@ static void amd_pstate_update(struct amd_cpudata
>>> *cpudata, u32 min_perf,
>>>
>>>     amd_pstate_update_perf(cpudata, min_perf, des_perf,
>>>                            max_perf, fast_switch);
>>> +
>>> +   cpufreq_cpu_put(policy);
>>>  }
>>>
>>>  static int amd_pstate_verify(struct cpufreq_policy_data *policy)
> 
> Thanks for the fix,   it needs to send v2 with the Fixes tag.
> 
> Reviewed-by: Perry Yuan <perry.yuan@amd.com>

Thanks, will send out v2 with fixes and rb tag

Regards,
Dhananjay

> 
> Best Regards.
> 
> Perry.