From: "Yajun Deng" <yajun.deng@linux.dev>
To: rmk+kernel@armlinux.org.uk, keescook@chromium.org,
gregkh@linuxfoundation.org, Jason@zx2c4.com, djwong@kernel.org,
ebiederm@xmission.com, thunder.leizhen@huawei.com,
ardb@kernel.org, wangkefeng.wang@huawei.com
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: Remove redundant arch_cpu_idle_prepare()
Date: Fri, 30 Dec 2022 09:16:26 +0000 [thread overview]
Message-ID: <fc13e5c0dba372ddb1435c959e7dc41f@linux.dev> (raw)
In-Reply-To: <20221201031306.2782204-1-yajun.deng@linux.dev>
December 1, 2022 11:13 AM, "Yajun Deng" <yajun.deng@linux.dev> wrote:
> arch_cpu_idle_prepare() was only called by cpu_startup_entry() and it is
> just a wrapper for local_fiq_enable().
>
> The local_fiq_enable() was already called before cpu_startup_entry().
>
> So remove redundant arch_cpu_idle_prepare().
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
> ---
> arch/arm/kernel/process.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index f811733a8fc5..e3f490ab95f4 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -81,11 +81,6 @@ void arch_cpu_idle(void)
> raw_local_irq_enable();
> }
>
> -void arch_cpu_idle_prepare(void)
> -{
> - local_fiq_enable();
> -}
> -
> void arch_cpu_idle_enter(void)
> {
> ledtrig_cpu(CPU_LED_IDLE_START);
> --
> 2.25.1
Ping.
prev parent reply other threads:[~2022-12-30 9:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 3:13 [PATCH] ARM: Remove redundant arch_cpu_idle_prepare() Yajun Deng
2022-12-30 9:16 ` Yajun Deng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc13e5c0dba372ddb1435c959e7dc41f@linux.dev \
--to=yajun.deng@linux.dev \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=djwong@kernel.org \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=thunder.leizhen@huawei.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox