From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 738F5C4167B for ; Tue, 5 Dec 2023 16:12:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345077AbjLEQMW (ORCPT ); Tue, 5 Dec 2023 11:12:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231929AbjLEQMT (ORCPT ); Tue, 5 Dec 2023 11:12:19 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BEF3E109 for ; Tue, 5 Dec 2023 08:12:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701792745; x=1733328745; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=wDtj9DdSJ7Y93+n4xPNycXhG5HoyUMQZ1DvGBkUKDxM=; b=QoAB0n3Tf/F6oP9TiDJSHof1WLkOoFWhY1Dh8BXGBZc7WFvpAXdT+WPn JXZbhB/vapwXS4xkQ3O3snJ8DDRz2XzlHW9/f2cpuY+Lnqh62c9HzKv8u H5/Z2RzFwlQCpQwaeOGQolsjmwuRRYTjPJwZWsBZ8Y2AfMVYzmcnG+19U aFIvNw4LrBGIAiCSseNlPXOpKKt01nps95FytKHjCFl590AG0bmveCDZ7 DUb408sqXCNaJSOXK2MUPjNNyauZmb5CDN3IF1HJFDPmXRAFo/GJnHrpT GJ6WR5NCFH1aDGA9+UlIITYaXxJHBldQ2622iUlir7qF2F7Uio+QKNIek Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="392781044" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="392781044" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 08:12:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="747290491" X-IronPort-AV: E=Sophos;i="6.04,252,1695711600"; d="scan'208";a="747290491" Received: from mbapna-mobl1.amr.corp.intel.com (HELO [10.212.151.198]) ([10.212.151.198]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2023 08:12:24 -0800 Message-ID: Date: Tue, 5 Dec 2023 10:12:23 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] ALSA: hda/tas2563: Add tas2563 HDA driver Content-Language: en-US From: Pierre-Louis Bossart To: Gergo Koteles , Shenghao Ding , Kevin Lu , Baojun Xu , Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org References: <4a2f31d4eb8479789ceb1daf2e93ec0e25c23171.1701733441.git.soyer@irl.hu> <90765ee0-a814-4852-9b2a-020cda98d930@linux.intel.com> <974d41f6c703d9b65ebcd75a2c659cecf13bd877.camel@irl.hu> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>> +static const struct dev_pm_ops tas2563_hda_pm_ops = { >>>> + SYSTEM_SLEEP_PM_OPS(tas2563_system_suspend, tas2563_system_resume) >>> >>> where's the pm_runtime stuff? >>> >> >> The amp stores its state in software shutdown mode. >> The tas2563_hda_playback_hook wakes/shutdowns the amp, not the >> pm_runtime. > > My point was that you have all these pm_runtime_ calls in the code, but > nothing that provides pm_runtime suspend-resume functions so not sure > what exactly the result is? if the inspiration was the tas2781, then see below it does have a RUNTIME_PM_OPS line as well as runtime_suspend/resume routines. static const struct dev_pm_ops tas2781_hda_pm_ops = { RUNTIME_PM_OPS(tas2781_runtime_suspend, tas2781_runtime_resume, NULL) SYSTEM_SLEEP_PM_OPS(tas2781_system_suspend, tas2781_system_resume) };