From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E00A91CEEAB for ; Wed, 4 Sep 2024 11:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725448304; cv=none; b=RP+VbtK2Fjh063nmugh4gmUq/1mJOi2rfhBT8AACQgz9DmFOgVbnhXwmNUriKf/qTvJzX9X5yGT1b/iUi/3h3fc4vhfworH49TkL6k0iTf/igezEO712qZl6VqiOhnGmkhiK6LWTqBdGRsreZM7H3irDsi9cWu1rpue86hFj2Gg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725448304; c=relaxed/simple; bh=6p/NFo/tFcfm4N94Q16yQt6X8yU/GtpzPyPRA714AqQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=B5T4DGg61PBoxr+1jU0lpuljsntJp0Y81NpyV7P4IjiOS8k4Vp8azozjNJHRts99hhOQEYU656PvbLFlPspBG2OjndalLk+FO6EJaFRmwUsOncxkWYfXCdqFKwzhyeHtKitwDkBnznXdv/O2f6ruVtGgn++0riac4+kqXjld9nU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=i2/L1mbC; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="i2/L1mbC" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1725448299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S0lV2xUFA9FxvbBRu83mg1/QrC+Ss19qIVjlT1geGEY=; b=i2/L1mbC02gPVhnDAHEINZ4E7ISvPWzp1v/q/oWWrdcQjFI9K83u5qLsGKAR1h4sWlB3MA IU8hK6V/ZrfS2E4uy4bDSGSdtzBMZCQG04i58qU7JBW1vo3TnmkEqh4eTjYkpoKe42qIVE uY4/LzYhue9fDbqDl6V/trGB2x/GQ2s= Date: Wed, 4 Sep 2024 12:11:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v3] net: enetc: Replace ifdef with IS_ENABLED To: Martyn Welch , Claudiu Manoil , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: kernel@collabora.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240904105143.2444106-1-martyn.welch@collabora.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20240904105143.2444106-1-martyn.welch@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 04/09/2024 11:51, Martyn Welch wrote: > The enetc driver uses ifdefs when checking whether > CONFIG_FSL_ENETC_PTP_CLOCK is enabled in a number of places. This works > if the driver is compiled in but fails if the driver is available as a > kernel module. Replace the instances of ifdef with use of the IS_ENABLED > macro, that will evaluate as true when this feature is built as a kernel > module and follows the kernel's coding style. > > Signed-off-by: Martyn Welch > Reviewed-by: Vadim Fedorenko If there will be v4, please, put yours SoB as the last tag after all other tags. Thanks, Vadim