linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Coiby Xu <coxu@redhat.com>, linux-integrity@vger.kernel.org
Cc: Karel Srot <ksrot@redhat.com>, Paul Moore <paul@paul-moore.com>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Petr Pavlu <petr.pavlu@suse.com>,
	Daniel Gomez <da.gomez@kernel.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	Roberto Sassu <roberto.sassu@huawei.com>,
	Dmitry Kasatkin	 <dmitry.kasatkin@gmail.com>,
	Eric Snowberg <eric.snowberg@oracle.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>, Fan Wu <wufan@kernel.org>,
	Stephen Smalley <stephen.smalley.work@gmail.com>,
	Ondrej Mosnacek <omosnace@redhat.com>,
	open list	 <linux-kernel@vger.kernel.org>,
	"open list:MODULE SUPPORT"	 <linux-modules@vger.kernel.org>,
	"open list:SECURITY SUBSYSTEM"	
	<linux-security-module@vger.kernel.org>,
	"open list:SELINUX SECURITY MODULE"	 <selinux@vger.kernel.org>
Subject: Re: [PATCH v3] ima: Access decompressed kernel module to verify appended signature
Date: Wed, 19 Nov 2025 08:29:22 -0500	[thread overview]
Message-ID: <fc1d67e411ef53460517db4c03bdcf1b9d9f8a8f.camel@linux.ibm.com> (raw)
In-Reply-To: <20251119034718.618008-1-coxu@redhat.com>

Hi Coiby,

On Wed, 2025-11-19 at 11:47 +0800, Coiby Xu wrote:
> Currently, when in-kernel module decompression (CONFIG_MODULE_DECOMPRESS)
> is enabled, IMA has no way to verify the appended module signature as it
> can't decompress the module.
> 
> Define a new kernel_read_file_id enumerate READING_MODULE_COMPRESSED so
> IMA can know only to collect original module data hash on
> READING_MODULE_COMPRESSED and defer appraising/measuring it until on
> READING_MODULE when the module has been decompressed.

This paragraph is a bit awkward.  Perhaps something like:

-> so IMA can calculate the compressed kernel module data hash and defer
measuring/appraising ...

> 
> Before enabling in-kernel module decompression, a kernel module in
> initramfs can still be loaded with ima_policy=secure_boot. So adjust the
> kernel module rule in secure_boot policy to allow either an IMA
> signature OR an appended signature i.e. to use
> "appraise func=MODULE_CHECK appraise_type=imasig|modsig".
> 
> Reported-by: Karel Srot <ksrot@redhat.com>
> Suggested-by: Mimi Zohar <zohar@linux.ibm.com>
> Suggested-by: Paul Moore <paul@paul-moore.com>
> Signed-off-by: Coiby Xu <coxu@redhat.com>

Thanks, Coiby!

The patch applies cleanly to linus' tree, but needs to be applied to next-
integrity.  Please re-base.

-- 

thanks,

Mimi

  reply	other threads:[~2025-11-19 13:30 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-28  3:03 [PATCH] ima: Fall back to default kernel module signature verification Coiby Xu
2025-09-30 13:57 ` Mimi Zohar
2025-09-30 20:28   ` Mimi Zohar
2025-10-16  3:46     ` Coiby Xu
2025-10-17  2:31       ` Mimi Zohar
2025-10-17  3:19         ` Coiby Xu
2025-10-17 17:49           ` Mimi Zohar
2025-10-17 23:19             ` Coiby Xu
2025-10-20 12:21               ` Mimi Zohar
2025-10-20 12:45                 ` Roberto Sassu
2025-10-20 13:57                   ` Mimi Zohar
2025-10-30  0:33                     ` Coiby Xu
2025-10-24 15:16                 ` Mimi Zohar
2025-10-30  0:31                   ` Coiby Xu
2025-10-30  3:01                     ` Mimi Zohar
2025-10-30 13:42                       ` Coiby Xu
2025-10-30 16:50                         ` Mimi Zohar
2025-10-31  7:58                           ` Coiby Xu
2025-10-02 17:17 ` kernel test robot
2025-10-16  3:51   ` Coiby Xu
2025-10-31  7:40 ` [PATCH v2] lsm,ima: new LSM hook security_kernel_module_read_file to access decompressed kernel module Coiby Xu
2025-11-01 16:50   ` Paul Moore
2025-11-02 15:05     ` Mimi Zohar
2025-11-02 15:43       ` Paul Moore
2025-11-05  0:18         ` Coiby Xu
2025-11-05  2:47           ` Paul Moore
2025-11-05 14:07             ` Mimi Zohar
2025-11-05 15:42               ` Paul Moore
2025-11-05 20:25                 ` Mimi Zohar
2025-11-06 13:35                   ` Coiby Xu
2025-11-05 20:47           ` Mimi Zohar
2025-11-06 13:29             ` Coiby Xu
2025-11-06 22:15               ` Mimi Zohar
2025-11-07 19:28                 ` Mimi Zohar
2025-11-13  4:06                   ` Coiby Xu
2025-11-18 12:19                     ` Mimi Zohar
2025-11-19  3:52                       ` Coiby Xu
2025-11-19  3:47   ` [PATCH v3] ima: Access decompressed kernel module to verify appended signature Coiby Xu
2025-11-19 13:29     ` Mimi Zohar [this message]
2025-11-19 14:05       ` Coiby Xu
2025-11-19 14:03   ` [PATCH v4] " Coiby Xu
2025-11-19 15:29     ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fc1d67e411ef53460517db4c03bdcf1b9d9f8a8f.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=coxu@redhat.com \
    --cc=da.gomez@kernel.org \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=eric.snowberg@oracle.com \
    --cc=jmorris@namei.org \
    --cc=ksrot@redhat.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    --cc=omosnace@redhat.com \
    --cc=paul@paul-moore.com \
    --cc=petr.pavlu@suse.com \
    --cc=roberto.sassu@huawei.com \
    --cc=samitolvanen@google.com \
    --cc=selinux@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=stephen.smalley.work@gmail.com \
    --cc=wufan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).